Make OpenEBS as a helm extension #3651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After giving this some more thought we cannot merge this because those with dynamic config may end up in a crash loop unable to modify their configuration. How should we deal with the situation when someone has both defined? |
juanluisvaladas
force-pushed
the
open-ebs
branch
2 times, most recently
from
7df72a0
to
5197a77
Compare
juanluisvaladas
force-pushed
the
open-ebs
branch
5 times, most recently
from
4af3f67
to
d1cd93d
Compare
4 tasks
|
The PR is marked as stale since no activity has been recorded in 30 days |
juanluisvaladas
force-pushed
the
open-ebs
branch
2 times, most recently
from
d5de429
to
07bb4da
Compare
|
I had forgotten about this and became stale. Can you please review this? the issue is solved |
twz123
reviewed
Dec 12, 2023
docs/storage.md
Outdated
|
|
||
| ### Installing 3rd party storage solutions | ||
|
|
||
| Follow your storage driver's installation instructions. Note that the Kubelet installed by k0s uses a slightly different path for its working directory (`/varlib/k0s/kubelet` instead of `/var/lib/kubelet`). Consult the CSI driver's configuration documentation on how to customize this path. |
There was a problem hiding this comment.
This should better mention the --data-dir flag, since the path is /path/to/data-dir/kubelet, and /var/lib/k0s happens to be the default for data-dir.
twz123
reviewed
Dec 12, 2023
juanluisvaladas
force-pushed
the
open-ebs
branch
3 times, most recently
from
c562117
to
da944d2
Compare
jnummelin
previously requested changes
Jan 15, 2024
juanluisvaladas
force-pushed
the
open-ebs
branch
2 times, most recently
from
32feaf5
to
6d3d6da
Compare
twz123
reviewed
Jan 18, 2024
juanluisvaladas
force-pushed
the
open-ebs
branch
4 times, most recently
from
93a0456
to
16783c5
Compare
|
I'm running the tests locally, they have failed so many times at this point I think they could be legit... |
|
Apparently the failures are legit, I broke something, perhaps the flag --single? |
|
OK found the issue fixing it now |
juanluisvaladas
force-pushed
the
open-ebs
branch
from
16783c5
to
8c83e52
Compare
twz123
reviewed
Jan 19, 2024
juanluisvaladas
force-pushed
the
open-ebs
branch
2 times, most recently
from
0b6aef2
to
5d35a0b
Compare
twz123
reviewed
Jan 22, 2024
| @@ -168,6 +168,7 @@ func GetWorkerFlags() *pflag.FlagSet { | |||
| } | |||
|
|
|||
| var availableComponents = []string{ | |||
| constant.ApplierManagerComponentName, | |||
There was a problem hiding this comment.
Just realizing this is newly added here. Could you update the string in the docs accordingly?
Line 525 in ed00ede
Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <[email protected]>
juanluisvaladas
force-pushed
the
open-ebs
branch
from
5d35a0b
to
713bd28
Compare
OpenEBS is migrated from `spec.extensions.storage` to helm. This is done for consistency with the rest of the documentation and allows to untie the OpenEBS version from the k0s version. This commit makes three changes: 1- Add the corresponding docs changes 2- Deprecate the storage API in kubebuilder 3- Ignore the extensions configuration if OpenEBS is defined as both a helm extension and a storage extension Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <[email protected]> Co-authored-by: Tom Wieczorek <[email protected]>
This is required for the OpenEBS test, this is extracted to a separate commit to make history a bit cleaner. Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <[email protected]>
Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <[email protected]> Co-authored-by: Tom Wieczorek <[email protected]>
Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <[email protected]>
juanluisvaladas
force-pushed
the
open-ebs
branch
from
713bd28
to
6aa4616
Compare
twz123
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OpenEBS is migrated from
spec.extensions.storageto helm. This is done for consistency with the rest of the documentation and allows to untie the OpenEBS version from the k0s version.This commit makes three changes:
1- Add the corresponding docs changes
2- Deprecate the storage API in kubebuilder
3- Force a panic if OpenEBS is defined as both a helm extension and a
storage extension
Fixes #3433
Type of change
How Has This Been Tested?
Checklist: