Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove StorageExtensions #4542

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Remove StorageExtensions #4542

merged 1 commit into from
Jul 10, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jun 4, 2024

Description

It's deprecated and marked to be ignored in 1.30.

See:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 added this to the 1.31 milestone Jun 4, 2024
@twz123 twz123 force-pushed the remove-storageext branch 2 times, most recently from f60129d to 3afe0a3 Compare June 5, 2024 11:14
@twz123 twz123 marked this pull request as ready for review June 5, 2024 11:43
@twz123 twz123 requested a review from a team as a code owner June 5, 2024 11:43
@twz123 twz123 requested review from kke and makhov June 5, 2024 11:43
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

This pull request has merge conflicts that need to be resolved.

jnummelin
jnummelin reviewed Jun 11, 2024
View reviewed changes
cmd/config/validate_test.go
Comment on lines +38 to +40
// NLLB cannot be used with external address
config.Spec.Network.NodeLocalLoadBalancing.Enabled = true
config.Spec.API.ExternalAddress = "k0s.example.com"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, is this really relevant for this PR? If removing openebs results this test being invalid/not-needed, maybe we should just remove the test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test checks the config validation in general, it's not specific to OpenEBS, but used it as an example for an invalid config. So I just picked the first other invalid config combination that came to my mind.

pkg/apis/k0s/v1beta1/extensions.go
// Deprecated: storage is deprecated and will be ignored starting from k0s
// 1.31 and onwards: https://docs.k0sproject.io/stable/examples/openebs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 1.30 we already say it's being ignored, now we're saying we'll ignore it 1.31 onwards. bit confusing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We said "and will be ignored in 1.30" (emphasis mine), but that never happened. This PR is now fulfilling that promise.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

This pull request has merge conflicts that need to be resolved.

@twz123
Remove StorageExtensions
3e4e576 
It's deprecated and marked to be ignored in 1.30.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 merged commit 2a7e939 into k0sproject:main Jul 10, 2024
81 checks passed
@twz123 twz123 deleted the remove-storageext branch July 10, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnummelin jnummelin jnummelin approved these changes

@kke kke Awaiting requested review from kke kke is a code owner automatically assigned from k0sproject/k0s-maintainers

@makhov makhov Awaiting requested review from makhov makhov is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
area/configuration chore
Projects
None yet
Milestone
1.31
Development

Successfully merging this pull request may close these issues.
2 participants
@twz123 @jnummelin