Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for FeatherGridContextMenu placement in cases where body height < document height (i.e. no page scrollbar) #443

Closed
wants to merge 18 commits into from
Closed

Bugfix for FeatherGridContextMenu placement in cases where body height < document height (i.e. no page scrollbar) #443

Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
73d62b4
Added fix for bug where context menu ends up far at the bottom of the…
Sep 7, 2023
3b8fd47
Fixed the math for the menu placement; works better in voila now.
Sep 7, 2023
e4e1988
Release 1.1.17
martinRenou Sep 5, 2023
6fd62e2
Unused import
martinRenou Sep 5, 2023
6671bef
Review comment
martinRenou Sep 7, 2023
d77a3ae
Remove __frontend_version__ variable
martinRenou Sep 7, 2023
c690bbb
Implement row setting
martinRenou Sep 5, 2023
e727b21
Fix bot for updating snapshots
martinRenou Sep 5, 2023
fa8a927
Bump actions/checkout from 3 to 4
dependabot[bot] Sep 5, 2023
5868e69
Added fix for bug where context menu ends up far at the bottom of the…
Sep 7, 2023
05f3393
Merge branch 'bloomberg:main' into menuchanges
alphaparrot Sep 8, 2023
12c887d
Merge branch 'menuchanges' of https://github.com/alphaparrot/ipydatag…
Sep 8, 2023
2a8ee5d
Fixed FeatherGridContextMenu placement bug in cases where body height…
Sep 8, 2023
e524a0e
Aligning package.json with upstream
Sep 8, 2023
6fba7fb
Merge branch 'main' into menuchanges
gaborbernat Dec 9, 2023
e2b773b
Merge branch 'main' into menuchanges
gaborbernat Dec 9, 2023
c8b1fd4
Merge branch 'main' into menuchanges
gaborbernat Dec 9, 2023
9272076
Merge branch 'main' into menuchanges
gaborbernat Dec 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions js/core/gridContextMenu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,8 @@ export class FeatherGridContextMenu extends GridContextMenu {
const py = window.pageYOffset;
const cw = document.documentElement.clientWidth;
const ch = document.documentElement.clientHeight;
const bodyh = document.documentElement.scrollHeight;
const scrollh = document.documentElement.scrollHeight;
const bodyh = document.body.offsetHeight;
var style = window.getComputedStyle(document.body);
const extraspaceX = parseFloat(style.marginLeft)+parseFloat(style.paddingLeft)+parseFloat(style.borderLeftWidth);
const extraspaceY = parseFloat(style.marginTop)+parseFloat(style.paddingTop)+parseFloat(style.borderTopWidth);
Expand Down Expand Up @@ -209,7 +210,13 @@ export class FeatherGridContextMenu extends GridContextMenu {
}

hitx = hitx - extraspaceX;
hity = hity - bodyh + extraspaceY;

// Following conditional branch accounts for incorrect math if body height is less than document height (no Y scrollbar)
if (scrollh == ch) {
hity = hity - bodyh;
} else {
hity = hity - scrollh + extraspaceY;
}

// Update the position of the menu to the computed position.
this._menu.node.style.transform = `translate(${Math.max(0, hitx)}px, ${hity}px`;
Expand Down
Loading