Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for FeatherGridContextMenu placement in cases where body height < document height (i.e. no page scrollbar) #443

Closed
wants to merge 18 commits into from
Closed

Bugfix for FeatherGridContextMenu placement in cases where body height < document height (i.e. no page scrollbar) #443

wants to merge 18 commits into from

Commits on Sep 7, 2023

  1. Added fix for bug where context menu ends up far at the bottom of the… 

    … page.

Fix involves correcting Lumino math that forces nonnegative y-coordinates.

Signed-off-by: Adiv Paradise <[email protected]>
    Adiv Paradise committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    73d62b4 View commit details
    Browse the repository at this point in the history

  2. Fixed the math for the menu placement; works better in voila now. 

    Signed-off-by: Adiv Paradise <[email protected]>
    Adiv Paradise committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    3b8fd47 View commit details
    Browse the repository at this point in the history

  3. Release 1.1.17 

    Signed-off-by: martinRenou <[email protected]>
    @martinRenou
    martinRenou authored and Adiv Paradise committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    e4e1988 View commit details
    Browse the repository at this point in the history

  4. Unused import 

    Signed-off-by: martinRenou <[email protected]>
    @martinRenou
    martinRenou authored and Adiv Paradise committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    6fd62e2 View commit details
    Browse the repository at this point in the history

  5. Review comment 

    Signed-off-by: martinRenou <[email protected]>
    @martinRenou
    martinRenou authored and Adiv Paradise committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    6671bef View commit details
    Browse the repository at this point in the history

  6. Remove __frontend_version__ variable 

    Signed-off-by: martinRenou <[email protected]>
    @martinRenou
    martinRenou authored and Adiv Paradise committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    d77a3ae View commit details
    Browse the repository at this point in the history

  7. Implement row setting 

    Signed-off-by: martinRenou <[email protected]>
    @martinRenou
    martinRenou authored and Adiv Paradise committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    c690bbb View commit details
    Browse the repository at this point in the history

  8. Fix bot for updating snapshots 

    Signed-off-by: martinRenou <[email protected]>
    @martinRenou
    martinRenou authored and Adiv Paradise committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    e727b21 View commit details
    Browse the repository at this point in the history

  9. Bump actions/checkout from 3 to 4 

    Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
    @dependabot
    dependabot[bot] authored and Adiv Paradise committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    fa8a927 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Added fix for bug where context menu ends up far at the bottom of the… 

    … page.

Fix involves correcting Lumino math that forces nonnegative y-coordinates.

Signed-off-by: Adiv Paradise <[email protected]>
    @gaborbernat
    Adiv Paradise authored and gaborbernat committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    5868e69 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'bloomberg:main' into menuchanges

    @alphaparrot
    alphaparrot authored Sep 8, 2023
    Configuration menu
    Copy the full SHA
    05f3393 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'menuchanges' of https://github.com/alphaparrot/ipydatag… 

    …rid-menuchanges into menuchanges

Signed-off-by: Adiv Paradise <[email protected]>
    Adiv Paradise committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    12c887d View commit details
    Browse the repository at this point in the history

  4. Fixed FeatherGridContextMenu placement bug in cases where body height… 

    … is substantially less than document (window) height, i.e. cases where no vertical scrollbar is rendered on the page

Signed-off-by: Adiv Paradise <[email protected]>
    Adiv Paradise committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    2a8ee5d View commit details
    Browse the repository at this point in the history

  5. Aligning package.json with upstream 

    Signed-off-by: Adiv Paradise <[email protected]>
    Adiv Paradise committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    e524a0e View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. Merge branch 'main' into menuchanges

    @gaborbernat
    gaborbernat authored Dec 9, 2023
    Configuration menu
    Copy the full SHA
    6fba7fb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into menuchanges

    @gaborbernat
    gaborbernat authored Dec 9, 2023
    Configuration menu
    Copy the full SHA
    e2b773b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into menuchanges

    @gaborbernat
    gaborbernat authored Dec 9, 2023
    Configuration menu
    Copy the full SHA
    c8b1fd4 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into menuchanges

    @gaborbernat
    gaborbernat authored Dec 9, 2023
    Configuration menu
    Copy the full SHA
    9272076 View commit details
    Browse the repository at this point in the history