Bugfix for FeatherGridContextMenu placement in cases where body height < document height (i.e. no page scrollbar) #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… page. Fix involves correcting Lumino math that forces nonnegative y-coordinates. Signed-off-by: Adiv Paradise <[email protected]>
Signed-off-by: Adiv Paradise <[email protected]>
Signed-off-by: martinRenou <[email protected]>
Signed-off-by: martinRenou <[email protected]>
Signed-off-by: martinRenou <[email protected]>
Signed-off-by: martinRenou <[email protected]>
Signed-off-by: martinRenou <[email protected]>
Signed-off-by: martinRenou <[email protected]>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
… page. Fix involves correcting Lumino math that forces nonnegative y-coordinates. Signed-off-by: Adiv Paradise <[email protected]>
…rid-menuchanges into menuchanges Signed-off-by: Adiv Paradise <[email protected]>
… is substantially less than document (window) height, i.e. cases where no vertical scrollbar is rendered on the page Signed-off-by: Adiv Paradise <[email protected]>
Signed-off-by: Adiv Paradise <[email protected]>
alphaparrot
changed the title
gaborbernat
suggested changes
Dec 9, 2023
|
Stalled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue number of the reported bug or feature request: #422 *
Describe your changes
Discovered a lingering bug in the FeatherGridContextMenu placement wherein the menu would be placed incorrectly in the event that the total body height is less than the document height, as might be the case on a large monitor. This fix tests for that condition (scrollHeight and clientHeight for the document will be equal), and uses the body height as the offset if so, and the scroll height minus padding+margins+border otherwise (the previous behaviour).
Testing performed
Same testing as before, with MWE notebook and full-featured notebook in voila and jupyter notebook, but now in both full-screen mode on a large monitor and smaller, windowed mode.