Krnlmon housekeeping #121
Merged
Krnlmon housekeeping #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed include/bf_pal, include/bf_types, and include/ipu_types
from all target_include_directories() commands.
1) The SDE abstraction layer (switchsde) is the only part of
krnlmon that is allowed to #include files from these
directories. All other parts of krnlmon must go through the
abstraction layer.
2) All #includes for SDE header files should be qualified by a
parent directory(e.g., #include "bf_types/bf_types.h").
This provides context for the reader as well as disambiguating
the reference. (There are are an awful lot of "utils.h" files
floating around.)
Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
ffoulkes
requested review from
nupuruttarwar,
n-sandeep,
vsureshkumarp and
5abeel
as code owners
ffoulkes
added
cmake
Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
- Updated file headers. - Deleted unused variables. - Removed an unnecessary extern "C" block. Signed-off-by: Derek G Foster <[email protected]>
Closed
ffoulkes
added
bazel
Signed-off-by: Derek G Foster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
include/bf_pal,include/bf_types, andinclude/ipu_typesfromtarget_include_directories()commands.switchsde).includedirectory, to work better with Bazel. This removes the need to specify anything but${SDE_INSTALL_DIR}/includein the directory path.Updated cmake file headers.
Removed redundant target properties.
switchapi/es2k/lnw_v2andswitchapi/es2k/lnw_v3cmake listfiles defined the same target properties as the parent listfile.switchapi/dpdkandswitchapi/es2klistfiles specify some of the same properties as their parent.Replaced a couple of
cc_library()calls withkrnlmon_cc_library().