Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Krnlmon housekeeping #121

Merged
merged 10 commits into from
Apr 18, 2024
Merged

Krnlmon housekeeping #121

merged 10 commits into from
Apr 18, 2024

Commits on Apr 12, 2024

  1. Remove p4 driver directories from cmake target include paths 

    - Removed include/bf_pal, include/bf_types, and include/ipu_types
  from all target_include_directories() commands.

  1) The SDE abstraction layer (switchsde) is the only part of
     krnlmon that is allowed to #include files from these
     directories. All other parts of krnlmon must go through the
     abstraction layer.

  2) All #includes for SDE header files should be qualified by a
     parent directory(e.g., #include "bf_types/bf_types.h").
     This provides context for the reader as well as disambiguating
     the reference. (There are are an awful lot of "utils.h" files
     floating around.)

Signed-off-by: Derek G Foster <[email protected]>
    @ffoulkes
    ffoulkes committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    4ed2f72 View commit details
    Browse the repository at this point in the history

  2. Update cmake file headers 

    Signed-off-by: Derek G Foster <[email protected]>
    @ffoulkes
    ffoulkes committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    d576bec View commit details
    Browse the repository at this point in the history

  3. Remove redundance target properties 

    Signed-off-by: Derek G Foster <[email protected]>
    @ffoulkes
    ffoulkes committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    1b39a11 View commit details
    Browse the repository at this point in the history

  4. Remove redundant target properties 

    Signed-off-by: Derek G Foster <[email protected]>
    @ffoulkes
    ffoulkes committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    d05d9b1 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. More housekeeping changes 

    Signed-off-by: Derek G Foster <[email protected]>
    @ffoulkes
    ffoulkes committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    4199e11 View commit details
    Browse the repository at this point in the history

  2. More housekeeping changes 

    Signed-off-by: Derek G Foster <[email protected]>
    @ffoulkes
    ffoulkes committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    c489e4b View commit details
    Browse the repository at this point in the history

  3. Reword NO_MATCH_ERROR message 

    Signed-off-by: Derek G Foster <[email protected]>
    @ffoulkes
    ffoulkes committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    4b6447e View commit details
    Browse the repository at this point in the history

  4. More housekeeping 

    - Updated file headers.
- Deleted unused variables.
- Removed an unnecessary extern "C" block.

Signed-off-by: Derek G Foster <[email protected]>
    @ffoulkes
    ffoulkes committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    7d87abb View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Merge branch 'main' into housekeeping

    @ffoulkes
    ffoulkes authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    c136064 View commit details
    Browse the repository at this point in the history

  2. Run buildifier to normalize bazel file 

    Signed-off-by: Derek G Foster <[email protected]>
    @ffoulkes
    ffoulkes committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    f1fc425 View commit details
    Browse the repository at this point in the history