Fix es2k bazel build #125
Closed
Fix es2k bazel build #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented a --//flags:lnw_version command-line flag that defines the configuration setting //flags:lnw_v2 or //flags:lnw_v3 if the lnw_version is 2 or 3 and the target is ES2K. - Modified krnlmon_cc_library() to define the preprocessor symbol LNW_V2 or LNW_V3 if the corresponding configuration setting is enabled. Signed-off-by: Derek G Foster <[email protected]>
- Combined the LNW_V2 and LNW_V3 versions of switch_pd_routing.h into a single conditionalized file. Subjectively, this is a little neater. Objectively, it solves a problem in adding Bazel support. Signed-off-by: Derek G Foster <[email protected]>
- Created switchapi/es2k/switch_pd_lag.h to act as a proxy for the version-specific switch_pd_lag.h files. It encapsulates the knowledge that there is more than one version of the header file. Signed-off-by: Derek G Foster <[email protected]>
- Revised the codebase and Bazel buildsystem to allow krnlmon to be built for ES2K with support for Linux Networking V2 or V3. A new --//flags:lnw_version command-line flag specifies the version to be enabled. Signed-off-by: Derek G Foster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Draft PR combines the following CLs:
with additional changes to:
--//flags:lnw_versioncommand-line flag to specify whether to build for LNW version 2 or version 3.It will be replaced by a smaller PR (consisting only of the additional changes) once PRs #121, #122, #123, and #124 have been merged.