Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update to Grafana 8.5.21 and 9.4.3 #44

Merged
merged 4 commits into from
Sep 2, 2023
Merged

CI: Update to Grafana 8.5.21 and 9.4.3 #44

merged 4 commits into from
Sep 2, 2023

Conversation

amotl
Copy link
Contributor

@amotl amotl commented Nov 30, 2022

What the title says.

@amotl
Copy link
Contributor Author

amotl commented Nov 30, 2022

@amotl amotl changed the title CI: Update to Grafana 9.3.0 CI: Update to Grafana 9.3.1 Dec 1, 2022
@amotl amotl marked this pull request as draft February 8, 2023 01:09
@amotl amotl changed the title CI: Update to Grafana 9.3.1 CI: Update to Grafana 8.5.21 and 9.4.3 Mar 5, 2023
@amotl
Copy link
Contributor Author

amotl commented Mar 5, 2023

1. Regression with HTTP status on HTTP DELETE

Grafana 8.5.21

It looks like the issue has apparently been fixed on the Grafana 8 series, specifically with Grafana 8.5.20, where the previous release 8.5.16 had the problem, while 8.5.15 was still ok.

image

grafana/grafana@v8.5.16...v8.5.20 has many changes, so it was not possible to identify the improving one yet.

Grafana 9.4.3

However, the problem is still present on Grafana 9.4.

-- https://github.com/panodata/grafana-wtf/actions/runs/4333757677/jobs/7567151287#step:5:2881

/cc @zuchka, @mildwonkey

@amotl
Copy link
Contributor Author

amotl commented Mar 5, 2023

2. Regression: user attribute in response changed

Grafana 9.4.3

When upgrading to Grafana 9.4, it looks like there has been another change. Where the API returned a user name within the user attribute beforehand, it now apparently returns the user's id.

Differing items:
{'user': 1} != {'user': 'admin'}

Full diff:
  {
   'folder': 'Testdrive',
   'message': '',
   'title': 'luftdaten.info generic trend v27',
   'url': 'http://localhost:33333/d/ioUrPwQiz/luftdaten-info-generic-trend-v27',
-  'user': 'admin',
+  'user': 1,
   'version': 1,
  }

-- https://github.com/panodata/grafana-wtf/actions/runs/4333757677/jobs/7567151287#step:5:3227

@amotl amotl marked this pull request as ready for review September 2, 2023 20:23
@amotl amotl merged commit 68df100 into main Sep 2, 2023
9 checks passed
@amotl amotl deleted the amo/grafana-9.3 branch September 2, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant