Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test suite by adding integration tests with Grafana #50

Open
amotl opened this issue Dec 1, 2022 · 1 comment
Open

Improve test suite by adding integration tests with Grafana #50

amotl opened this issue Dec 1, 2022 · 1 comment

Comments

@amotl
Copy link
Contributor

amotl commented Dec 1, 2022

Hi there,

currently, grafana-client employs testing solely by mocking HTTP conversations. Because this does not cover real integration tests with Grafana, it is easy to miss regressions, like those which recently happened here.

On the other hand, both grafana-wtf, and Kotori, already feature such an integration test suite with Grafana. In this manner, the grafana-wtf test harness was able to catch this issue.

So, grafana-client will need to adopt that test suite soon, in order to improve compatibility and QA on different versions of Grafana, by adding them to a test matrix.

grafana-wtf/tests can be an inspiration for this. While being at it, we may split this off into a generic pytest-grafana package, in the same spirit like the recently conceived pytest-mqtt package.

With kind regards,
Andreas.

@amotl
Copy link
Contributor Author

amotl commented Oct 30, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant