Regression with delete_folder in Grafana 9.3.0

[amotl]

What API call do you use?

grafana.folder.delete_folder(uid=folder_uid) ¹

What is the actual output?

requests.exceptions.JSONDecodeError: [Errno Expecting value] : 0 ²

What is the expected output?

It worked before on Grafana 9.2.4.

References

• CI: Update to Grafana 8.5.21 and 9.4.3 grafana-wtf#44

Footnotes

1. https://github.com/panodata/grafana-wtf/actions/runs/3582719496/jobs/6027277338#step:5:1888 ↩

2. https://github.com/panodata/grafana-wtf/actions/runs/3582719496/jobs/6027277338#step:5:1935 ↩

[amotl]

By analyzing the output on CI, it looks like the endpoint is responding with 200 OK, but yields an empty response body. Maybe it should respond with 204 No Content instead? See #44.

[amotl]

I've been able to reproduce the regression, and confirm the observation referenced above.

it looks like the endpoint is responding with 200 OK, but yields an empty response body.

This makes JSON parsers croak.

Grafana 9.2.7

docker run --rm -it --publish=3000:3000 --env='GF_SECURITY_ADMIN_PASSWORD=admin' grafana/grafana:9.2.7

HTTP folder create/delete conversation on Grafana 9.2

sink:grafana-wtf amo$ http --auth=admin:admin POST localhost:3000/api/folders title=foobar
HTTP/1.1 200 OK
Cache-Control: no-cache
Content-Length: 278
Content-Type: application/json
Date: Wed, 30 Nov 2022 11:33:30 GMT
Expires: -1
Pragma: no-cache
X-Content-Type-Options: nosniff
X-Frame-Options: deny
X-Xss-Protection: 1; mode=block

{
    "canAdmin": true,
    "canDelete": true,
    "canEdit": true,
    "canSave": true,
    "created": "2022-11-30T11:33:30Z",
    "createdBy": "admin",
    "hasAcl": false,
    "id": 1,
    "title": "foobar",
    "uid": "pyENC4KVz",
    "updated": "2022-11-30T11:33:30Z",
    "updatedBy": "admin",
    "url": "/dashboards/f/pyENC4KVz/foobar",
    "version": 1
}


sink:grafana-wtf amo$ http --auth=admin:admin DELETE localhost:3000/api/folders/pyENC4KVz
HTTP/1.1 200 OK
Cache-Control: no-cache
Content-Length: 59
Content-Type: application/json
Date: Wed, 30 Nov 2022 11:33:57 GMT
Expires: -1
Pragma: no-cache
X-Content-Type-Options: nosniff
X-Frame-Options: deny
X-Xss-Protection: 1; mode=block

{
    "id": 1,
    "message": "Folder foobar deleted",
    "title": "foobar"
}

Grafana 9.3.0

docker run --rm -it --publish=3000:3000 --env='GF_SECURITY_ADMIN_PASSWORD=admin' grafana/grafana:9.3.0

HTTP folder create/delete conversation on Grafana 9.3.0

sink:grafana-wtf amo$ http --auth=admin:admin POST localhost:3000/api/folders title=foobar
HTTP/1.1 200 OK
Cache-Control: no-cache
Content-Length: 313
Content-Type: application/json
Date: Wed, 30 Nov 2022 11:34:16 GMT
Expires: -1
Pragma: no-cache
X-Content-Type-Options: nosniff
X-Frame-Options: deny
X-Xss-Protection: 1; mode=block

{
    "canAdmin": true,
    "canDelete": true,
    "canEdit": true,
    "canSave": true,
    "created": "2022-11-30T11:34:16.024847779Z",
    "createdBy": "admin",
    "hasAcl": false,
    "id": 1,
    "parentUid": "",
    "title": "foobar",
    "uid": "8EmOC4K4z",
    "updated": "2022-11-30T11:34:16.024847824Z",
    "updatedBy": "admin",
    "url": "/dashboards/f/8EmOC4K4z/foobar",
    "version": 1
}


sink:grafana-wtf amo$ http --auth=admin:admin DELETE localhost:3000/api/folders/8EmOC4K4z
HTTP/1.1 200 OK
Cache-Control: no-cache
Content-Length: 0
Content-Type: application/json
Date: Wed, 30 Nov 2022 11:34:24 GMT
Expires: -1
Pragma: no-cache
X-Content-Type-Options: nosniff
X-Frame-Options: deny
X-Xss-Protection: 1; mode=block

[amotl]

I've reported the observations at grafana/grafana#59546.

[amotl]

On a recent version of Grafana, there is a non-empty response again now.

$ http --auth=admin:admin DELETE localhost:3000/api/folders/8EmOC4K4z
HTTP/1.1 404 Not Found
Cache-Control: no-store
Content-Length: 51
Content-Type: application/json
Date: Fri, 29 Mar 2024 10:40:34 GMT
X-Content-Type-Options: nosniff
X-Frame-Options: deny
X-Xss-Protection: 1; mode=block

{
    "message": "folder not found",
    "status": "not-found"
}