Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ros_gz_sim.launch.py when create_own_container is enabled (backport #620) #621

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 17, 2024

🦟 Bug fix

I noticed that running the following example:

ros2 launch ros_gz_sim ros_gz_sim.launch.py world_sdf_file:=sensors_demo.sdf bridge_name:=ros_gz_bridge config_file:=/home/caguero/ros_gz_ws/src/ros_gz/ros_gz_bridge/test/config/full.yaml use_composition:=True create_own_container:=True

duplicates the number of running nodes and containers.

caguero@cold:~/ros_gz_ws$ ros2 node list
/gz_server
/gz_server
/launch_ros_1390503
/ros_gz_bridge
/ros_gz_bridge
/ros_gz_container
/ros_gz_container

After this patch:

caguero@cold:~/ros_gz_ws$ ros2 node list
/gz_server
/launch_ros_1395505
/ros_gz_bridge
/ros_gz_container

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #620 done by Mergify.

@ahcorde ahcorde merged commit 739cb42 into jazzy Oct 18, 2024
6 checks passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-620 branch October 18, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants