Fix ros_gz_sim.launch.py when create_own_container is enabled #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Agüero <[email protected]>
ahcorde
requested changes
Oct 17, 2024
| @@ -92,20 +103,10 @@ def generate_launch_description(): | |||
| ('config_file', config_file), | |||
| ('container_name', container_name), | |||
| ('namespace', namespace), | |||
| ('create_own_container', str(False)), | |||
There was a problem hiding this comment.
this is hardcoded, is this right ?
There was a problem hiding this comment.
That's on purpose, to make sure that only one container is used.
ahcorde
approved these changes
Oct 17, 2024
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Carlos Agüero <[email protected]> (cherry picked from commit a4d00a9)
8 tasks
ahcorde
pushed a commit
that referenced
this pull request
Oct 18, 2024
…#621) Signed-off-by: Carlos Agüero <[email protected]> (cherry picked from commit a4d00a9) Co-authored-by: Carlos Agüero <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
I noticed that running the following example:
duplicates the number of running nodes and containers.
After this patch:
Summary
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.