Name Gazebo sim node #611
Merged
Name Gazebo sim node #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nabeel Sherazi <[email protected]>
ahcorde
approved these changes
Sep 16, 2024
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
Signed-off-by: Nabeel Sherazi <[email protected]> (cherry picked from commit 64b8acd)
8 tasks
ahcorde
pushed a commit
that referenced
this pull request
Sep 16, 2024
Signed-off-by: Nabeel Sherazi <[email protected]> (cherry picked from commit 64b8acd) Co-authored-by: Nabeel Sherazi <[email protected]>
Amronos
pushed a commit
to Amronos/ros_gz
that referenced
this pull request
Sep 18, 2024
Signed-off-by: Nabeel Sherazi <[email protected]> (cherry picked from commit 64b8acd) Co-authored-by: Nabeel Sherazi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #610
This is my first PR to this repo, it is super minor, but let me know if I have not followed any contributing instructions!
Summary
Adds a name to the Gazebo node started, so that it doesn't appear as
ruby $(which gz) sim-1(Harmonic) orruby $(which ign) gazebo-1(Fortress)Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.