Change world_string to model_string in gz_spawn_model files #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changed description from XML string to XML(SDF) string Signed-off-by: Aarav Gupta <[email protected]>
Signed-off-by: Aarav Gupta <[email protected]>
9 tasks
caguero
approved these changes
Sep 12, 2024
|
Thanks! |
Amronos
added a commit
to Amronos/ros_gz
that referenced
this pull request
Sep 12, 2024
…m#606) * Change world_string to model_string Also changed description from XML string to XML(SDF) string Signed-off-by: Aarav Gupta <[email protected]>
Amronos
added a commit
to Amronos/ros_gz
that referenced
this pull request
Sep 18, 2024
…m#606) * Change world_string to model_string Also changed description from XML string to XML(SDF) string Signed-off-by: Aarav Gupta <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Updates
world_stringtomodel_stringin some files which were not updated in #605.cc @caguero
Summary
Updates
world_stringtomodel_stringin some files which were not updated in #605.Also changed the description from
XML stringtoXML(SDF) stringChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.