Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep rolling on Jammy and apply a temporary fix for rosdep #522

Merged
merged 6 commits into from
Mar 29, 2024
Merged

Keep rolling on Jammy and apply a temporary fix for rosdep #522

merged 6 commits into from
Mar 29, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Mar 28, 2024

🦟 Bug fix

Summary

Pins rosdep to a known good version based on https://wiki.ros.org/SnapshotRepository

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey requested a review from ahcorde as a code owner March 28, 2024 20:44
@azeey
Try a different approach
963b52a 
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey
Install git
3421371 
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey
Yet another approach
75e0aac 
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey
Try initial approach with correct tag
23f49f2 
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from mjcarroll March 28, 2024 21:57
@azeey
Revert unnecessary change
483744a 
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey merged commit 230adc5 into ros2 Mar 29, 2024
5 checks passed
@azeey azeey deleted the fix_rolling_ci branch March 29, 2024 17:37
caguero pushed a commit that referenced this pull request Mar 29, 2024
@azeey @caguero
Keep rolling on Jammy and apply a temporary fix for rosdep (#522)
022d4c6 
Pins rosdep to a known good version based on https://wiki.ros.org/SnapshotRepository

---------

Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

@ahcorde ahcorde Awaiting requested review from ahcorde ahcorde is a code owner

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azeey @iche033