Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport rolling] Add ROS namespaces to GZ topics #517

Merged
merged 3 commits into from
Apr 1, 2024
Merged

[Backport rolling] Add ROS namespaces to GZ topics #517

merged 3 commits into from
Apr 1, 2024

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Mar 25, 2024

🦟 Backport

#512

Summary

Backport #512

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Kotochleb and others added 2 commits March 25, 2024 19:28
@Kotochleb @ahcorde
Add ROS namespaces to GZ topics (#512)
28d7ee0 
Signed-off-by: Kotochleb <[email protected]>
Signed-off-by: Krzysztof Wojciechowski <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde
Fixed merge
c611047 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde requested a review from mjcarroll March 25, 2024 18:29
@ahcorde ahcorde self-assigned this Mar 25, 2024
@ahcorde ahcorde mentioned this pull request Mar 25, 2024
Merged
azeey
azeey reviewed Mar 25, 2024
View reviewed changes
ros_gz_bridge/README.md Outdated

```bash
# Shell B:
ign topic -e -t /demo/chatter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gz.

@ahcorde
Added feedback
795c9b6 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde merged commit 596eb1c into ros2 Apr 1, 2024
3 of 7 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/bp/512 branch April 1, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey approved these changes

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahcorde @azeey @mjcarroll @Kotochleb