-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ROS namespaces to GZ topics #512
Add ROS namespaces to GZ topics #512
Conversation
a539d6c
to
36ddd38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing https://build.ros2.org/job/Ipr__ros_gz__ubuntu_jammy_amd64/79/#showFailuresLink
Do you mind to sign the commit ?
f178f1b
to
43fc776
Compare
@ahcorde I applied your suggestions and signed the commits |
hmm, not sure why this is trying to run |
@azeey do you think I should just wait for the CI to be solved on your side? It doesn't seem to be broken by my changes |
Yes, this is unrelated to your PR. Hopefully, we'll have a fix soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some documentation in the README ?
Signed-off-by: Kotochleb <[email protected]>
Signed-off-by: Kotochleb <[email protected]>
Signed-off-by: Kotochleb <[email protected]>
Signed-off-by: Kotochleb <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Krzysztof Wojciechowski <[email protected]> Signed-off-by: Kotochleb <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Krzysztof Wojciechowski <[email protected]> Signed-off-by: Kotochleb <[email protected]>
Signed-off-by: Kotochleb <[email protected]>
Signed-off-by: Kotochleb <[email protected]>
bdd4e28
to
1df4159
Compare
Signed-off-by: Kotochleb <[email protected]>
@ahcorde I added new section about the remapping to the README.md. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some more minor comment, otherwise looks good to me
Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Krzysztof Wojciechowski <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Krzysztof Wojciechowski <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Krzysztof Wojciechowski <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Krzysztof Wojciechowski <[email protected]>
@Kotochleb thank you for your contribution, do you have some time to do the forward port in |
@ahcorde you are welcome. I would have time, but it will take me a few more days, as this feature for Humble was something I needed right now. Hopefully I will submit the PRs till end of this week. |
Signed-off-by: Kotochleb <[email protected]> Signed-off-by: Krzysztof Wojciechowski <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Kotochleb <[email protected]> Signed-off-by: Krzysztof Wojciechowski <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
🎉 New feature
Summary
This PR adds the ability to apply ROS node namespace onto GZ topics. This adds option for global namespaces, private namespaces and should also work for substitutions.
I believe this feature later could be easily ported to Iron and Rolling.
As it is an API breaking feature, I also introduced a new ROS parameter, preserving backward compatibility.
Test it
In the
config_file
YAML file, create topics as:This should create ROS topics:
And GZ topics: