Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable test failing due to ODE/libccd (backport #621) #642

Merged
merged 1 commit into from
May 21, 2024

Conversation

Blast545
Copy link
Contributor

🦟 Bug fix

Fixes CI on physics2 + Homebew,
Reference: https://build.osrfoundation.org/job/gz_physics-ci-ign-physics2-homebrew-amd64/43/testReport/

Backports: 13bf7f5
It is not a direct backport, because the file was different, and I changed the logic because the tested code is directly in a dartsim folder.

Summary

Disable test failing on homebrew and tag issue tracking it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened gazebo-tooling/release-tools#1143 to report the noble abichecker job being triggered for this PR when it should not be. Otherwise this looks good

@scpeters scpeters merged commit 966265b into ign-physics2 May 21, 2024
10 of 11 checks passed
@scpeters scpeters deleted the blast545/backport_621_to_physics2 branch May 21, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants