Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: packaging breaks on cyclic dependencies #94

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix: packaging breaks on cyclic dependencies #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/main/groovy/io/gatling/gradle/GatlingEnterprisePackageTask.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,11 @@ class GatlingEnterprisePackageTask extends Jar {
}

private void collectDepAndChildren(ResolvedDependency dep, Set<ResolvedDependency> acc) {
acc.add(dep)
for (child in dep.children) {
collectDepAndChildren(child, acc)
if (!acc.contains(dep)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So cool.
But I'm just wondering how the user end up in this situation, compilers don't like cyclic dependencies in my memories, I'm curious to know how such a jar is generated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scope of these dependencies is runtime, not compile.

acc.add(dep)
for (child in dep.children) {
collectDepAndChildren(child, acc)
}
}
}
}