Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: packaging breaks on cyclic dependencies #94

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix: packaging breaks on cyclic dependencies #94

merged 1 commit into from
Jan 29, 2024

Commits on Jan 29, 2024

  1. fix: packaging breaks on cyclic dependencies 

    Motivation:

- grpc-java has two modules that depend on each other, causing circular
  recursion on the collectDepAndChildren function

Modification:

- stop the recursion if the accumulator already contains a dependency

Result:

- stackoverflowless
    @notdryft
    notdryft committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    2723c1e View commit details
    Browse the repository at this point in the history