fix: packaging breaks on cyclic dependencies #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: - grpc-java has two modules that depend on each other, causing circular recursion on the collectDepAndChildren function Modification: - stop the recursion if the accumulator already contains a dependency Result: - stackoverflowless
notdryft
requested review from
Isammoc,
slandelle,
guilgaly and
bastien-gatling
bastien-gatling
approved these changes
Jan 29, 2024
| acc.add(dep) | ||
| for (child in dep.children) { | ||
| collectDepAndChildren(child, acc) | ||
| if (!acc.contains(dep)) { |
There was a problem hiding this comment.
So cool.
But I'm just wondering how the user end up in this situation, compilers don't like cyclic dependencies in my memories, I'm curious to know how such a jar is generated.
There was a problem hiding this comment.
The scope of these dependencies is runtime, not compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Modification:
Result: