Add progress bar for mcap convert
#973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narasaka
commented
Sep 14, 2023
go/ros/bag2mcap.go
Outdated
| @@ -225,7 +232,7 @@ func channelIDForConnection(connID uint32) (uint16, error) { | |||
| return uint16(connID), nil | |||
| } | |||
|
|
|||
| func Bag2MCAP(w io.Writer, r io.Reader, opts *mcap.WriterOptions) error { | |||
| func Bag2MCAP(w io.Writer, r io.Reader, opts *mcap.WriterOptions, progressBar *progressbar.ProgressBar) error { | |||
There was a problem hiding this comment.
I feel like i should just put the progress bar in this function instead of injecting it 🤷
There was a problem hiding this comment.
that does seem nicer, but you'd just need to pass in a messageCount.
Maybe the cleanest option would be to pass in the *Info struct, and then construct the progress bar in here? You need to call Info() outside this function (as you do) or else you would need to pass this a ReadSeeker, which you're not in position to do.
|
This looks great generally. The thing that's not clear to me is this: the 1606 needs some units, and I have no idea what "it/s" is. I guess that's the conversion rate? We can probably either remove that, or change it to a MB/sec computation. |
wkalt
reviewed
Sep 18, 2023
wkalt
reviewed
Sep 20, 2023
go/ros/bag2mcap.go
Outdated
| @@ -173,6 +173,10 @@ func processBag( | |||
| } | |||
| } | |||
|
|
|||
| if err != nil { | |||
| return err | |||
| } | |||
wkalt
reviewed
Sep 20, 2023
go/ros/ros2db3_to_mcap.go
Outdated
|
|
||
| if err != nil { | ||
| return fmt.Errorf("failed to increment progress bar: %w", err) | ||
| } |
wkalt
reviewed
Sep 20, 2023
go/go.work
Outdated
| @@ -1,4 +1,6 @@ | |||
| go 1.18 | |||
| go 1.21 | |||
wkalt
approved these changes
Sep 20, 2023
This adds a progressbar to the `convert` command to show percentage completion of converting from both ros and db3 to mcap.
narasaka
force-pushed
the
nathan/fg-4674-progress-bar-for-mcap-convert
branch
from
f985b99
to
5fcd91f
Compare
pezy
pushed a commit
to pezy/mcap
that referenced
this pull request
Jan 11, 2024
### Public-Facing Changes This adds a progress bar to show percentage completion when running `mcap convert ...`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
This adds a progress bar when running
mcap convert ...