Address comments

foxglove · Sep 20, 2023 · f985b99 · f985b99
1 parent f5825c8
commit f985b99
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 14 deletions.
diff --git a/go/go.work b/go/go.work
@@ -1,6 +1,4 @@
-go 1.21
-
-toolchain go1.21.0
+go 1.18
 
 use (
 	./cli/mcap

diff --git a/go/ros/bag2mcap.go b/go/ros/bag2mcap.go
@@ -173,10 +173,6 @@ func processBag(
 			}
 		}
 
-		if err != nil {
-			return err
-		}
-
 		switch opcode[0] {
 		case OpBagHeader:
 			continue

diff --git a/go/ros/ros2db3_to_mcap.go b/go/ros/ros2db3_to_mcap.go
@@ -319,10 +319,6 @@ func DB3ToMCAP(w io.Writer,
 		if err != nil {
 			return fmt.Errorf("failed to write channel info: %w", err)
 		}
-
-		if err != nil {
-			return fmt.Errorf("failed to increment progress bar: %w", err)
-		}
 	}
 	seq := make(map[uint16]uint32)
 	err = transformMessages(db, func(rows *sql.Rows) error {

diff --git a/testdata/db3/chatter.mcap b/testdata/db3/chatter.mcap