feat(frontend): add IC transactions to unified list util #3568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterpeterparker
approved these changes
Nov 15, 2024
| @@ -95,8 +106,24 @@ export const mapAllTransactionsUi = ({ | |||
| } | |||
|
|
|||
| if (isNetworkIdICP(networkId)) { | |||
| // TODO: Implement ICP transactions | |||
| return acc; | |||
| // TODO: Implement ckBTC and ckETH pending transactions | |||
There was a problem hiding this comment.
Unsolicited feedback: the more you provide PR for this feature, the more I think it's unrealisitc in terms of performance but, let's see.
There was a problem hiding this comment.
yes... the final version is not exactly good; we should really start thinking about caching
|
|
||
| export const createMockIcTransactionsUi = (n: number): IcTransactionUi[] => | ||
| Array.from({ length: n }, () => ({ | ||
| id: Math.random().toString(36).substring(7), |
AntonioVentilii
deleted the
feat(frontend)/add-IC-transactions-to-unified-list-util
branch
AntonioVentilii
added a commit
that referenced
this pull request
Nov 15, 2024
# Motivation After PR #3568, we add the IC transactions in the UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Following PR #3547 , we add the IC transactions to the util that unifies the transactions.
Tests
Provided additional tests.