-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): add IC transactions to unified list util #3568
Merged
AntonioVentilii
merged 8 commits into
main
from
feat(frontend)/add-IC-transactions-to-unified-list-util
Nov 15, 2024
+118
−11
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
aea387e
feat(frontend): add IC transactions to unified list util
AntonioVentilii a448df9
lint: clean
AntonioVentilii b8196c0
Merge branch 'main' into feat(frontend)/add-IC-transactions-to-unifie…
AntonioVentilii 65163e6
Merge branch 'main' into feat(frontend)/add-IC-transactions-to-unifie…
AntonioVentilii 200a87f
test: add tests
AntonioVentilii 2c3df4b
🤖 Apply formatting changes
github-actions[bot] d222787
use random crypto id
AntonioVentilii 3ee596d
Merge branch 'main' into feat(frontend)/add-IC-transactions-to-unifie…
AntonioVentilii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import type { IcTransactionUi } from '$icp/types/ic-transaction'; | ||
|
||
export const createMockIcTransactionsUi = (n: number): IcTransactionUi[] => | ||
Array.from({ length: n }, () => ({ | ||
id: crypto.randomUUID(), | ||
type: 'send', | ||
status: 'executed' | ||
})); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsolicited feedback: the more you provide PR for this feature, the more I think it's unrealisitc in terms of performance but, let's see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes... the final version is not exactly good; we should really start thinking about caching