Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): add IC transactions in AllTransactionsList #3589

Conversation

AntonioVentilii
Copy link
Collaborator

Motivation

After PR #3568, we add the IC transactions in the UI.

@AntonioVentilii AntonioVentilii requested a review from a team as a code owner November 15, 2024 14:08

beforeEach(() => {
beforeAll(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it expected to run it just once now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes indeed! since I just want to set once for the entire test, I just need the stores to be non-empty for all of them

Copy link
Contributor

@DenysKarmazynDFINITY DenysKarmazynDFINITY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small question, approving already.

@AntonioVentilii AntonioVentilii merged commit 809e5dc into main Nov 15, 2024
14 checks passed
@AntonioVentilii AntonioVentilii deleted the feat(frontend)/add-IC-transactions-in-AllTransactionsList branch November 15, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants