-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve TL;DR documentation for starters #215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to have this a couple of months ago 😅
Awesome work!! This is much better than what we have at the moment, for sure.
I have some small improvements
ports: | ||
- "8000:8000" | ||
depends_on: | ||
- redis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is for production, shouldn't we add restart: unless-stopped
for all the services?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, although I imagine a real production docker-compose pulling a image directly from dockerhub instead of building it here. Let's say that this also work for development
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, production configurations can be very personal. I imagine most people would use a Nginx service integrated here instead of exposing the 8000 port form rails.
Also, when the notion.so manuals are migrated to docs/ and https://docs.decidim.org/bulletin-board/, then we should link at the beginning and the ending of this guide to have a full detailed explanation, but I really like having the TLDR in the README 👍🏽 👍🏽 |
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
This are really good news! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes @andreslucena, I let you a couple of comments.
ports: | ||
- "8000:8000" | ||
depends_on: | ||
- redis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, production configurations can be very personal. I imagine most people would use a Nginx service integrated here instead of exposing the 8000 port form rails.
@microstudi Going through these open issues at bulletin board. Are you planning to continue working on this or should we close it? We would need to rebase/merge with develop and address the possible feedback. I haven't tried out the docker compose setup yet because I am unsure if you will continue working on this. |
We should close this one in favor of #309 |
Closing this one as we're moving forward with #309 |
I've found quite impossible to install this and make it work.
This PR is an attempt to document a little bit better the steps needed in order for this to work properly with a Decidim installation.