Upgrade bulletin version to 0.24.4 #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yodide-17 # Conflicts: # Dockerfile # Dockerfile.release # bulletin_board/server/db/seeds.rb # voting_schemes/electionguard/docker/pyodide-electionguard/Dockerfile # voting_schemes/electionguard/docker/pyodide-electionguard/packages/libgmp/Makefile # voting_schemes/electionguard/docker/pyodide-electionguard/packages/libgmp/checksums # voting_schemes/electionguard/python-to-js/build # voting_schemes/electionguard/python-wrapper/Pipfile.lock # voting_schemes/electionguard/python-wrapper/integration_results.jsonl # voting_schemes/electionguard/python-wrapper/src/bulletin_board/electionguard/trustee.py # voting_schemes/electionguard/python-wrapper/tests/test_integration.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #309 +/- ##
========================================
Coverage 69.57% 69.57%
========================================
Files 96 96
Lines 1630 1630
========================================
Hits 1134 1134
Misses 496 496 ☔ View full report in Codecov by Sentry. |
microstudi
changed the title
andreslucena
requested changes
Nov 20, 2023
There was a problem hiding this comment.
I didn't actually run the code changes directly, but as this is the version from docker hub and you have been using that for a couple weeks I think we can be sure that it's working 😄
Really outstanding documentation, thanks for the effort. I have some changes in format and we're good to go
voting_schemes/electionguard/python-wrapper/src/bulletin_board/electionguard/bulletin_board.py
Outdated
Show resolved
Hide resolved
|
Changes applied @andreslucena ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #308