-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve TL;DR documentation for starters #215
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1ceb428
add docker compose
microstudi 35c076b
command isntructions
microstudi db19fd1
add depends on
microstudi 0d77eeb
Do not expose redis ports
microstudi d84dfbf
Update bulletin_board/server/README.md
microstudi 65a6d1b
Update bulletin_board/server/README.md
microstudi 169f9ec
Update bulletin_board/server/README.md
microstudi d35c70c
Update bulletin_board/server/README.md
microstudi 4a01465
Update bulletin_board/server/README.md
microstudi 31eafef
Update bulletin_board/server/README.md
microstudi 76f7fc4
Update bulletin_board/server/README.md
microstudi a5b2f9f
Remove uneeded lines
microstudi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,14 @@ | ||
# frozen_string_literal: true | ||
|
||
if Rails.env.production? || ENV["SANDBOX"] | ||
redis_host = ENV["REDIS_HOST"] || "localhost" | ||
redis_port = ENV["REDIS_PORT"] || 6379 | ||
|
||
Sidekiq.configure_server do |config| | ||
config.redis = { ssl_params: { verify_mode: OpenSSL::SSL::VERIFY_NONE } } | ||
config.redis = {host: redis_host, port: redis_port, ssl_params: { verify_mode: OpenSSL::SSL::VERIFY_NONE } } | ||
end | ||
|
||
Sidekiq.configure_client do |config| | ||
config.redis = { ssl_params: { verify_mode: OpenSSL::SSL::VERIFY_NONE } } | ||
config.redis = {host: redis_host, port: redis_port, ssl_params: { verify_mode: OpenSSL::SSL::VERIFY_NONE } } | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
version: "3.9" | ||
services: | ||
bulletin: | ||
build: | ||
context: . | ||
dockerfile: Dockerfile.release | ||
env_file: .env | ||
environment: | ||
- RAILS_LOG_TO_STDOUT=1 | ||
- RAILS_SERVE_STATIC_FILES=1 | ||
- RACK_ENV=production | ||
- RAILS_ENV=production | ||
- REDIS_HOST=redis | ||
- REDIS_PORT=6379 | ||
volumes: | ||
- ./docker-entrypoint.sh:/docker-entrypoint.sh | ||
entrypoint: /docker-entrypoint.sh | ||
command: "" | ||
ports: | ||
- "8000:8000" | ||
depends_on: | ||
- redis | ||
|
||
worker: | ||
build: | ||
context: . | ||
dockerfile: Dockerfile.release | ||
env_file: .env | ||
environment: | ||
- RAILS_LOG_TO_STDOUT=1 | ||
- RACK_ENV=production | ||
- RAILS_ENV=production | ||
- REDIS_HOST=redis | ||
- REDIS_PORT=6379 | ||
command: "" | ||
volumes: | ||
- ./docker-entrypoint-worker.sh:/docker-entrypoint.sh | ||
entrypoint: /docker-entrypoint.sh | ||
depends_on: | ||
- redis | ||
|
||
redis: | ||
image: "redis:alpine" | ||
command: redis-server | ||
volumes: | ||
- redis_data:/data | ||
|
||
volumes: | ||
redis_data: |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is for production, shouldn't we add
restart: unless-stopped
for all the services?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, although I imagine a real production docker-compose pulling a image directly from dockerhub instead of building it here. Let's say that this also work for development
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, production configurations can be very personal. I imagine most people would use a Nginx service integrated here instead of exposing the 8000 port form rails.