[windows] updated v5.4.0 #65

seanyen · 2020-04-14T03:45:29Z

Checklist

Used a fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

conda-forge-linter · 2020-04-14T03:45:34Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

license_file entry is missing, but is required.

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

seanyen · 2020-04-14T03:45:46Z

@conda-forge-admin, please rerender

conda-forge-linter · 2020-04-14T03:47:02Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

seanyen · 2020-04-14T03:48:05Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2020.04.14.00.23.16

seanyen · 2020-04-14T04:07:47Z

@conda-forge/suitesparse This is a version bump and ready for review and merge. Thanks!

jschueller · 2020-04-14T05:43:55Z

please rebase from master, it's 5.7.2 now

seanyen · 2020-04-14T15:31:25Z

@jschueller

It looks like the SuiteSparse for Windows build lives for its own on this separate branch since this and it takes the source from this project instead: https://github.com/jlblancoc/suitesparse-metis-for-windows, which attempts to keep CMake recipes for cross-platform compiling and now it is ported to v5.4.0.

I don't think doing a simple rebase of this feedstock can take it to v5.7.2. Or maybe I misread your comments? What's the step I should take?

jschueller · 2020-04-14T15:48:50Z

oh, right, I did not see that.

seanyen · 2020-04-15T17:29:23Z

@conda-forge/suitesparse @conda-forge/core This is ready for review and merge. Thanks!

beckermr · 2020-04-15T18:41:32Z

pls only bump the team and not core on these. We can help if this is not merged for about a week or so.

isuruf · 2020-04-15T18:43:27Z

recipe/meta.yaml

    - {{ compiler('c') }}
    - {{ compiler('cxx') }}
  host:
    - blas 1.1 {{ variant }}
    - openblas
-    - tbb
-    - metis

  run:
    - blas 1.1 {{ variant }}
    - openblas


This needs to be changed to the blas scheme mentioned in the docs

@isuruf Are you talking about this? https://conda-forge.readthedocs.io/en/latest/blas.html Is there any existing PR as the example how to properly add blas as dependency? I did read the doc, however I am still scratching my head how to do it right in conda-build recipe.

isuruf · 2020-04-15T18:43:43Z

recipe/meta.yaml

  patches:
    - gh_56.patch  # [win]

 build:
-  skip: true  # [win32 or unix]
-  number: 202
+  number: 0
  features:
    - blas_{{ variant }}


Remove these 2 lines.

seanyen · 2020-04-15T20:32:45Z

@conda-forge-admin, please rerender.

github-actions · 2020-04-15T20:34:20Z

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

seanyen · 2020-04-16T00:48:00Z

@isuruf Btw, I saw there are some warnings like these:

Do you recommend to add libopenblas to the run requirements? Currently I am only adding blas meta-package as the run dependency.

WARNING (suitesparse,Library\bin\cholmod.dll): Needed DSO Library\bin\openblas.dll found in ['libopenblas']
WARNING (suitesparse,Library\bin\cholmod.dll): .. but ['libopenblas'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)

…nda-forge-pinning 2020.04.15.23.38.20

seanyen · 2020-04-16T15:01:34Z

@isuruf hmm, the CI seems not to like the changes. What should we do for the next step?

isuruf · 2020-04-16T15:20:31Z

Try deleting %PREFIX%/Library/lib/cmake/ ?

seanyen · 2020-04-16T15:37:49Z

@isuruf Just wondering, what's the latest doc for how to integrate with blas? Is this one still up-to-dated? https://conda-forge.readthedocs.io/en/latest/blas.html

isuruf · 2020-04-16T15:49:15Z

It's the one at https://conda-forge.org/docs/maintainer/knowledge_base.html#blas

seanyen · 2020-04-16T15:56:43Z

I see, so I probably looked at a old site (https://conda-forge.readthedocs.io/) instead of the latest one (https://conda-forge.org/docs/index.html).

isuruf · 2020-04-16T16:11:21Z

Thanks. I'll see if I can get that old site deleted.

seanyen · 2020-04-16T21:47:54Z

@conda-forge/suitesparse Friendly ping. I think this is ready for merge. Thanks.

h-vetinari · 2020-04-17T15:31:14Z

Great to see this happening. I was planning to get around to doing this myself after having built suitesparse for windows within conda-forge/cvxopt-feedstock#42.

I detailed some of that in #51 - I believe (hope?) that metis is not necessary and that we can go to 5.7.2 directly.

seanyen · 2020-04-17T18:14:41Z

Great to see this happening. I was planning to get around to doing this myself after having built suitesparse for windows within conda-forge/cvxopt-feedstock#42.

Happy to see the progress on this too. For my short-term goal, I just want to have ceres Windows port with suitesparse enabled, so I can do a conda-forge feedstock for https://github.com/cartographer-project/cartographer. And I am happy to see any attempts to get it converged toward to that direction. :)

grlee77 · 2020-04-17T19:37:46Z

I am inclined to go ahead and merge this soon given that it is now passing CI. That said, I don't have experience with Windows + SuitSparse/METIS and would appreciate any feedback from other maintainers.

h-vetinari · 2020-04-18T17:49:52Z

@seanyen True, there's no reason not to merge this, any progress can come on top of this PR.

seanyen · 2020-04-18T19:52:55Z

Thank you all!

updated v5.4.0

ec66901

lint fix.

59ed5c5

MNT: Re-rendered with conda-build 3.19.2, conda-smithy 3.6.16, and co…

bcb58bf

…nda-forge-pinning 2020.04.14.00.23.16

seanyen changed the title ~~updated v5.4.0~~ [windows] updated v5.4.0 Apr 14, 2020

seanyen mentioned this pull request Apr 14, 2020

Enable ceres & suitesparse for Windows. conda-forge/ceres-solver-feedstock#10

Merged

5 tasks

jschueller mentioned this pull request Apr 15, 2020

Update to 5.7.2 jlblancoc/suitesparse-metis-for-windows#98

Closed

isuruf reviewed Apr 15, 2020

View reviewed changes

attempt to fix blas deps.

aece224

isuruf and others added 2 commits April 15, 2020 19:56

Use the example from docs

e01be73

MNT: Re-rendered with conda-build 3.19.2, conda-smithy 3.6.16, and co…

64af82f

…nda-forge-pinning 2020.04.15.23.38.20

try to remove lapack cmake folder.

9b6a910

basnijholt added the automerge Merge the PR when CI passes label Apr 18, 2020

basnijholt merged commit 14469bf into conda-forge:windows Apr 18, 2020

seanyen mentioned this pull request Apr 18, 2020

[suitespare] updated the pinning to the latest 5.4 for Windows. conda-forge/conda-forge-pinning-feedstock#564

Merged

5 tasks

seanyen deleted the seanyen/windows branch April 18, 2020 19:52

minrk mentioned this pull request May 9, 2024

add Windows #92

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[windows] updated v5.4.0 #65

[windows] updated v5.4.0 #65

seanyen commented Apr 14, 2020 •

edited

Loading

conda-forge-linter commented Apr 14, 2020

seanyen commented Apr 14, 2020

conda-forge-linter commented Apr 14, 2020

seanyen commented Apr 14, 2020

seanyen commented Apr 14, 2020

jschueller commented Apr 14, 2020

seanyen commented Apr 14, 2020 •

edited

Loading

jschueller commented Apr 14, 2020

seanyen commented Apr 15, 2020

beckermr commented Apr 15, 2020

isuruf Apr 15, 2020

seanyen Apr 15, 2020

isuruf Apr 15, 2020

seanyen commented Apr 15, 2020 •

edited by isuruf

Loading

github-actions bot commented Apr 15, 2020

seanyen commented Apr 16, 2020

seanyen commented Apr 16, 2020

isuruf commented Apr 16, 2020 •

edited

Loading

seanyen commented Apr 16, 2020 •

edited

Loading

isuruf commented Apr 16, 2020

seanyen commented Apr 16, 2020

isuruf commented Apr 16, 2020

seanyen commented Apr 16, 2020

h-vetinari commented Apr 17, 2020 •

edited

Loading

seanyen commented Apr 17, 2020

grlee77 commented Apr 17, 2020

h-vetinari commented Apr 18, 2020

seanyen commented Apr 18, 2020

[windows] updated v5.4.0 #65

[windows] updated v5.4.0 #65

Conversation

seanyen commented Apr 14, 2020 • edited Loading

conda-forge-linter commented Apr 14, 2020

seanyen commented Apr 14, 2020

conda-forge-linter commented Apr 14, 2020

seanyen commented Apr 14, 2020

seanyen commented Apr 14, 2020

jschueller commented Apr 14, 2020

seanyen commented Apr 14, 2020 • edited Loading

jschueller commented Apr 14, 2020

seanyen commented Apr 15, 2020

beckermr commented Apr 15, 2020

isuruf Apr 15, 2020

Choose a reason for hiding this comment

seanyen Apr 15, 2020

Choose a reason for hiding this comment

isuruf Apr 15, 2020

Choose a reason for hiding this comment

seanyen commented Apr 15, 2020 • edited by isuruf Loading

github-actions bot commented Apr 15, 2020

seanyen commented Apr 16, 2020

seanyen commented Apr 16, 2020

isuruf commented Apr 16, 2020 • edited Loading

seanyen commented Apr 16, 2020 • edited Loading

isuruf commented Apr 16, 2020

seanyen commented Apr 16, 2020

isuruf commented Apr 16, 2020

seanyen commented Apr 16, 2020

h-vetinari commented Apr 17, 2020 • edited Loading

seanyen commented Apr 17, 2020

grlee77 commented Apr 17, 2020

h-vetinari commented Apr 18, 2020

seanyen commented Apr 18, 2020

seanyen commented Apr 14, 2020 •

edited

Loading

seanyen commented Apr 14, 2020 •

edited

Loading

seanyen commented Apr 15, 2020 •

edited by isuruf

Loading

isuruf commented Apr 16, 2020 •

edited

Loading

seanyen commented Apr 16, 2020 •

edited

Loading

h-vetinari commented Apr 17, 2020 •

edited

Loading