Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suitespare] updated the pinning to the latest 5.4 for Windows. #564

Merged
merged 3 commits into from
Apr 22, 2020

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented Apr 18, 2020

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@seanyen seanyen requested a review from a team as a code owner April 18, 2020 19:51
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@seanyen
Copy link
Contributor Author

seanyen commented Apr 18, 2020

Now the suitesparse for Windows has been updated to 5.4 with the latest blas convention. I am suggesting to update the pinning.
conda-forge/suitesparse-feedstock#65
conda-forge/suitesparse-feedstock#66

@seanyen
Copy link
Contributor Author

seanyen commented Apr 20, 2020

@conda-forge/core This is ready for review and merge. Thanks!

@CJ-Wright
Copy link
Member

This most likely needs a migration

Copy link
Member

@CJ-Wright CJ-Wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a migration (most likely)

@seanyen
Copy link
Contributor Author

seanyen commented Apr 21, 2020

This needs a migration (most likely)

@CJ-Wright What does that mean? How do I make it happen?

@CJ-Wright
Copy link
Member

Put a copy of this file in the migrations folder of this repo.
Then modify the file to match the changes you made here:

suitesparse:
  - 5.6                # [not win]
  - 5.4                # [win]

@seanyen
Copy link
Contributor Author

seanyen commented Apr 21, 2020

@CJ-Wright Thanks for the tip! Hope I get the migration description right...

@isuruf
Copy link
Member

isuruf commented Apr 21, 2020

Btw, how many existing packages use suitesparse on windows? I assume one or two

@@ -589,7 +589,7 @@ sqlite:
- 3
suitesparse:
- 5.6 # [not win]
- 5.1 # [win]
- 5.4 # [win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to remove this change this will go in once the migration has finished.

@seanyen
Copy link
Contributor Author

seanyen commented Apr 22, 2020

Btw, how many existing packages use suitesparse on windows? I assume one or two

@isuruf Frankly I don't know. Any commands to quickly check it? And it seems to me that there are two ways: Pinning a version in conda_build_config.yaml or adding a migrator. What's the consideration which to use?

@isuruf
Copy link
Member

isuruf commented Apr 22, 2020

Looks like it is only cvxopt. (Inspected https://conda.anaconda.org/conda-forge/win-64/repodata.json)
So, if you can revert back to the original commit, I'll merge.

There's no point doing a migration for 1 package.

@seanyen
Copy link
Contributor Author

seanyen commented Apr 22, 2020

@isuruf Done. I removed the migrator file.

@isuruf isuruf added the automerge Merge the PR when CI passes label Apr 22, 2020
@github-actions github-actions bot merged commit 6b8ed28 into conda-forge:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants