-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[suitespare] updated the pinning to the latest 5.4 for Windows. #564
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Now the |
@conda-forge/core This is ready for review and merge. Thanks! |
This most likely needs a migration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a migration (most likely)
@CJ-Wright What does that mean? How do I make it happen? |
Put a copy of this file in the suitesparse:
- 5.6 # [not win]
- 5.4 # [win] |
@CJ-Wright Thanks for the tip! Hope I get the migration description right... |
Btw, how many existing packages use suitesparse on windows? I assume one or two |
@@ -589,7 +589,7 @@ sqlite: | |||
- 3 | |||
suitesparse: | |||
- 5.6 # [not win] | |||
- 5.1 # [win] | |||
- 5.4 # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to remove this change this will go in once the migration has finished.
@isuruf Frankly I don't know. Any commands to quickly check it? And it seems to me that there are two ways: Pinning a version in |
Looks like it is only cvxopt. (Inspected https://conda.anaconda.org/conda-forge/win-64/repodata.json) There's no point doing a migration for 1 package. |
@isuruf Done. I removed the migrator file. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)