Enable ceres & suitesparse for Windows. #10

seanyen · 2020-04-14T01:13:48Z

Checklist

Used a fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

conda-forge-linter · 2020-04-14T01:13:53Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

seanyen · 2020-04-14T01:14:14Z

@conda-forge-admin, please rerender

seanyen · 2020-04-14T01:42:14Z

hmm, it seems the suitesparse-feedstock needs a new build?

Package openblas conflicts for:
suitesparse=5.1 -> openblas[version='0.2.20|0.2.20.*|>=0.3.3,<0.3.4.0a0']
openblas=0.3.6
suitesparse=5.1 -> blas==1.1=openblas -> openblas
blas==1.1=openblas -> openblas

seanyen · 2020-04-14T04:08:15Z

Waiting for this. conda-forge/suitesparse-feedstock#65

jschueller · 2020-04-14T05:41:44Z

recipe/meta.yaml

  skip: true  # [win and vc<14]
+  features:  # [win]
+    - blas_{{ variant }}  # [win]


the blas variant feature is deprecated, please remove this

jschueller · 2020-04-14T05:42:17Z

recipe/meta.yaml

+    - libcblas  # [unix]
+    - liblapack  # [unix]
+    - blas 1.1 {{ variant }}  # [win]
+    - openblas  # [win]


here too, remove blas variant & openblas

jschueller · 2020-04-14T17:41:17Z

recipe/meta.yaml

@@ -1,4 +1,5 @@
 {% set version = "1.14.0" %}
+{% set variant = "openblas" %}


you can also drop this

jschueller · 2020-04-14T17:41:27Z

recipe/meta.yaml

    - tbb
    - eigen

  run:
+    - blas 1.1  # [win]


seanyen · 2020-04-14T18:12:48Z

@conda-forge-admin, please rerender

seanyen · 2020-04-14T18:13:50Z

@jschueller Thanks for those tips! It seems now the conda is happy about the dependencies.

seanyen · 2020-04-14T20:36:08Z

@jschueller Btw, I am adding myself as a co-maintainer. Hope you don't mind. :)

seanyen · 2020-04-15T08:48:45Z

@jschueller Sorry to spam again. I think now the change is ready for merge. I am planning to add https://github.com/cartographer-project/cartographer feedstock and which depends on this change. Thanks!

jschueller · 2020-04-15T09:24:59Z

recipe/meta.yaml

+    - libblas  # [unix]
+    - libcblas  # [unix]
+    - liblapack  # [unix]
+    - blas 1.1  # [win]


blas 1.1 should not be here either

seanyen · 2020-04-15T16:00:36Z

@conda-forge-admin, please rerender

jschueller · 2020-04-15T16:38:12Z

recipe/meta.yaml

@@ -26,7 +26,7 @@ requirements:
    - libblas  # [unix]
    - libcblas  # [unix]
    - liblapack  # [unix]
-    - blas 1.1  # [win]
+    - blas  # [win]


there is no blas package, only libblas

Sorry I don’t follow. What does that mean? Btw, for the original my change, I was following https://conda-forge.readthedocs.io/en/latest/blas.html and the example in suitesparse-feedstock. I am pretty much just “monkey see monkey do”.

You dont need this since ceres doesnt care about the implementation: libblas is enough.

Ah, I see. Just a thought, maybe for easier maintenance, we can remove the libblas, libclas, and liblapack all together? They are deps from suitesparse anyway.

seanyen · 2020-04-15T17:00:06Z

@conda-forge-admin, please rerender

github-actions · 2020-04-15T17:02:04Z

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

seanyen · 2020-04-16T14:58:49Z

@jschueller Let me know any additional changes to make. Hope we can get this enabled for Windows build. Thanks.

conda-forge-linter · 2020-04-18T19:45:52Z

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-linter · 2020-04-19T01:12:11Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

seanyen · 2020-04-19T01:12:50Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2020.04.18.00.00.57

seanyen · 2020-04-19T05:18:26Z

@jschueller The new suitesparse is merged and now on the conda-forge. And this is ready for review and merge. Thanks!

jschueller · 2020-04-19T05:45:39Z

you build with suitesparse 5.4 but for runtime 5.1 is still pulled, this seems inconsistent to me.
maybe you'd want to pin suitesparse to 5.4 for the run requirements too, unless the pinning update gets merged first:
conda-forge/conda-forge-pinning-feedstock#564

seanyen · 2020-04-21T01:02:10Z

@jschueller Thanks for pointing out the version issue. I added the run_exports to the suitesparse, and by that way it should pull the version with it built against. conda-forge/suitesparse-feedstock#66

seanyen · 2020-04-22T03:05:29Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2020.04.22.02.05.22

seanyen · 2020-04-22T03:47:30Z

@jschueller Finally the suitesparse pinning went through! And the CI looks green and consumes the latest 5.4 suitesparse for Windows.

jschueller reviewed Apr 14, 2020

View reviewed changes

recipe/meta.yaml Outdated

@@ -1,4 +1,5 @@

{% set version = "1.14.0" %}

{% set variant = "openblas" %}

Copy link

Contributor

jschueller Apr 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also drop this

jschueller reviewed Apr 14, 2020

View reviewed changes

recipe/meta.yaml Outdated

- tbb

- eigen

run:

- blas 1.1 # [win]

Copy link

Contributor

jschueller Apr 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this

seanyen marked this pull request as ready for review April 14, 2020 18:12

jschueller reviewed Apr 15, 2020

View reviewed changes

seanyen marked this pull request as draft April 18, 2020 19:53

add suitesparse for Windows.

8c80164

seanyen force-pushed the seanyen/windows branch from a07c7f5 to 8c80164 Compare April 19, 2020 01:12

MNT: Re-rendered with conda-build 3.19.2, conda-smithy 3.6.16, and co…

d9826e1

…nda-forge-pinning 2020.04.18.00.00.57

seanyen marked this pull request as ready for review April 19, 2020 05:17

Update meta.yaml

8f5d32b

MNT: Re-rendered with conda-build 3.19.2, conda-smithy 3.6.16, and co…

c24f8d4

…nda-forge-pinning 2020.04.22.02.05.22

jschueller merged commit f8be20e into conda-forge:master Apr 22, 2020

seanyen deleted the seanyen/windows branch April 22, 2020 17:40

ericpre mentioned this pull request Oct 20, 2020

Use suitesparse on Windows conda-forge/match-series-feedstock#10

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable ceres & suitesparse for Windows. #10

Enable ceres & suitesparse for Windows. #10

seanyen commented Apr 14, 2020 •

edited

Loading

conda-forge-linter commented Apr 14, 2020

seanyen commented Apr 14, 2020

seanyen commented Apr 14, 2020

seanyen commented Apr 14, 2020

jschueller Apr 14, 2020

jschueller Apr 14, 2020

jschueller Apr 14, 2020

jschueller Apr 14, 2020

seanyen commented Apr 14, 2020

seanyen commented Apr 14, 2020

seanyen commented Apr 14, 2020

seanyen commented Apr 15, 2020

jschueller Apr 15, 2020

seanyen commented Apr 15, 2020

jschueller Apr 15, 2020

seanyen Apr 15, 2020

jschueller Apr 15, 2020

seanyen Apr 15, 2020 •

edited

Loading

seanyen commented Apr 15, 2020

github-actions bot commented Apr 15, 2020

seanyen commented Apr 16, 2020

conda-forge-linter commented Apr 18, 2020

conda-forge-linter commented Apr 19, 2020

seanyen commented Apr 19, 2020

seanyen commented Apr 19, 2020

jschueller commented Apr 19, 2020

seanyen commented Apr 21, 2020

seanyen commented Apr 22, 2020

seanyen commented Apr 22, 2020

		@@ -1,4 +1,5 @@
		{% set version = "1.14.0" %}
		{% set variant = "openblas" %}

Enable ceres & suitesparse for Windows. #10

Enable ceres & suitesparse for Windows. #10

Conversation

seanyen commented Apr 14, 2020 • edited Loading

conda-forge-linter commented Apr 14, 2020

seanyen commented Apr 14, 2020

seanyen commented Apr 14, 2020

seanyen commented Apr 14, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seanyen commented Apr 14, 2020

seanyen commented Apr 14, 2020

seanyen commented Apr 14, 2020

seanyen commented Apr 15, 2020

Choose a reason for hiding this comment

seanyen commented Apr 15, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seanyen Apr 15, 2020 • edited Loading

Choose a reason for hiding this comment

seanyen commented Apr 15, 2020

github-actions bot commented Apr 15, 2020

seanyen commented Apr 16, 2020

conda-forge-linter commented Apr 18, 2020

conda-forge-linter commented Apr 19, 2020

seanyen commented Apr 19, 2020

seanyen commented Apr 19, 2020

jschueller commented Apr 19, 2020

seanyen commented Apr 21, 2020

seanyen commented Apr 22, 2020

seanyen commented Apr 22, 2020

seanyen commented Apr 14, 2020 •

edited

Loading

seanyen Apr 15, 2020 •

edited

Loading