win: learn from anaconda #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-vetinari
requested review from
jakirkham,
jjhelmus and
martinandersen
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2020.03.24
|
First step: suiteparse builds on windows. :) I am getting some build warnings: I'll try to get rid of them, but I'm confused why it's talking about |
|
OTOH, this means we might try building in https://github.com/conda-forge/suitesparse-feedstock directly...? |
|
@conda-forge/cvxopt Not sure if the merge from ATM, the Would be nice of course to also build for openblas/blis on windows, and to externalise the building of suiteparse to it's proper feedstock (cf. conda-forge/suitesparse-feedstock#51), but I think that can be done independently of this PR. |
|
Hi! This is the friendly automated conda-forge-webservice. |
1 similar comment
|
Hi! This is the friendly automated conda-forge-webservice. |
|
@conda-forge-admin, please rerender |
h-vetinari
force-pushed
the
master
branch
4 times, most recently
from
951ecab
to
77ee3ef
Compare
|
Alright. I couldn't get blis/openblas to work, reverting to a green build. A sample error (from a win-openblas build): |
|
Thanks for putting this together @h-vetinari. Looks good to me. |
This was referenced Mar 28, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Main takeaway is: build suitesparse in this feedstock. For more details see this comment
Closes #41
Closes #23