blas variants for windows #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-vetinari
requested review from
jakirkham,
jjhelmus and
martinandersen
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2020.03.24
|
@conda-forge-admin, please rerender |
|
@conda-forge-admin, please rerender. |
|
Hi! This is the friendly automated conda-forge-webservice. |
|
Sorry for all the thrashing around, I tried linking everything I could think of to resolve the following missing symbols: that seem to be in The install instructions for suiteparse talk about:
I'm not sure how |
|
First of all, why do you want to build for different variants? Does |
|
Thanks for the response. The windows builds used to depend (until #42) on the last available suiteparse version (which isn't being built for windows currently), which caused strong restrictions in the solver (#41). In the AnacondaRecipe, the solution was to build suiteparse directly in the |
|
@isuruf
Also, without |
…nda-forge-pinning 2020.03.28
h-vetinari
commented
Mar 28, 2020
|
You need to remove https://github.com/DrTimothyAldenDavis/SuiteSparse/blob/430586d0b796d1a377172f21c3e1bc572878a61a/UMFPACK/Source/cholmod_blas.h#L47 line. Then building with netlib will work. Please have a look at https://conda-forge.org/docs/maintainer/knowledge_base.html#blas . We are building with netlib, but at runtime it will be MKL on windows by default. |
|
Thanks a lot, @isuruf! :) Not sure how I should have guessed that it's necessary to remove |
isuruf
reviewed
Mar 28, 2020
|
@conda-forge/cvxopt, this is green now, thanks to @isuruf's advice. :) |
|
@conda-forge/cvxopt Hope everyone's back refreshed from weekend, here's another ping before it slides off my "recent activity" in GH. ;-) |
|
LGTM |
h-vetinari
added a commit
to h-vetinari/cvxopt-feedstock
that referenced
this pull request
Apr 15, 2020
h-vetinari
added a commit
to h-vetinari/cvxopt-feedstock
that referenced
this pull request
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Trying to resolve #43.
I couldn't figure out why the libs weren't found in #42 when I tried to build for openblas/blis, but I guess I didn't get the names right. This time, I compared with the outputs from the respective feedstocks (and learned that the cvxopt-builder looks for ".lib" and not ".dll").
Feedback welcome!