Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SFC #3379

Merged
merged 5 commits into from
Jun 14, 2023
Merged

Remove SFC #3379

merged 5 commits into from
Jun 14, 2023

Conversation

sequencer
Copy link
Member

@sequencer sequencer commented May 30, 2023 •
edited
Loading

This PR removes the entire usage to SFC, some annotation still remains, but no transforms/stage exist. This will pave the path to Chisel5 support.

Impact: API modification

Development Phase: implementation

Release Notes
Drop support to legacy SFC APIs

@sequencer sequencer changed the base branch from master to dev May 30, 2023 10:39
@sequencer sequencer enabled auto-merge June 14, 2023 16:44
@sequencer sequencer merged commit 2a9936d into dev Jun 14, 2023
@sequencer sequencer deleted the farewell_sfc branch June 14, 2023 16:51
@ZenithalHourlyRate
Copy link
Contributor

Extra note on this PR in case someone bisected:

  1. This breaks the make workflow for the dev branch
  2. The mill flow (usage demoed in github actions) currently does not support repl-seq-mem so the RAM generated is only for emulator, and Xilinx FPGA BRAM inference will fail. If you need to bring rocket to FPGA, try master branch.

@cyyself cyyself mentioned this pull request Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZenithalHourlyRate ZenithalHourlyRate ZenithalHourlyRate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sequencer @ZenithalHourlyRate