Add divide by zero check to BigInteger mod #22774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Abraham <[email protected]>
these are used to implement mod operators with less code duplication Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
bmcdonald3
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
This looks good to me. The one thing that I was thinking of that may make sense would be to use boundsChecking, rather than chpl_checkDivByZero, since that is what we typically use for module-level halts, but I think since this one is specifically divide by zero checks, I feel fine with how you've gone here.
3 tasks
jabraham17
added a commit
that referenced
this pull request
Jan 11, 2024
Removes almost all of the remaining BigInteger deprecations This PR removes the deprecations from the following PRs I authored - #22775 - #22888/#22774 - #22818 - #22794 - #22788 - #22121 I also removed the remaining deprecations done by Yash Raj - #18855 - #18827 I moved one test out of the deprecated/BigInteger directory, `bigint_getlimbs.chpl`, since its not a deprecation test and actually checks functionality. Testing - [x] paratest without comm - [x] paratest with comm - [x] built docs and checked them [Reviewed by @ShreyasKhandekar]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a divide by zero check to
BigInteger.mod,BigInteger.%andBigInteger.%=to match the divide functions (#19384). While doing this work, implemented part of the change for argument names (#19005 (comment)).Summary of changes
modmodin terms of thedivRwith the proper rounding argumentmodTruncby aintegralto reduce code duplicationa/bonmodin favor ofx/yNew tests
test/library/standard/BigInteger/modByZero.chpltest/deprecated/BigInteger/argumentNames.chplTesting
[Reviewed by @bmcdonald3]
closes #19384
closes cray/chapel-private#5094