Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add divide by zero check to BigInteger mod #22774

Merged
merged 8 commits into from
Jul 20, 2023
Merged

Add divide by zero check to BigInteger mod #22774

merged 8 commits into from
Jul 20, 2023

Commits on Jul 19, 2023

  1. add divide by zero checks to mod, removes duplicated code 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    4eca675 View commit details
    Browse the repository at this point in the history

  2. add private modTrunc helpers with div checks 

    these are used to implement mod operators with less code duplication

Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    511313c View commit details
    Browse the repository at this point in the history

  3. add mod divide by zero test 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    557ac9c View commit details
    Browse the repository at this point in the history

  4. fix wrong variable name usage 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    ecb7c55 View commit details
    Browse the repository at this point in the history

  5. rename mod arguments to x and y 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    ad792b9 View commit details
    Browse the repository at this point in the history

  6. add deprecation tests 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    7c50d98 View commit details
    Browse the repository at this point in the history

  7. cleanup comment 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    988e496 View commit details
    Browse the repository at this point in the history

  8. add extra tests for %= 

    Signed-off-by: Jade Abraham <[email protected]>
    @jabraham17
    jabraham17 committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    74824c1 View commit details
    Browse the repository at this point in the history