Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated BigInteger functions #24175

Merged
merged 15 commits into from
Jan 11, 2024
Merged

Remove deprecated BigInteger functions #24175

merged 15 commits into from
Jan 11, 2024

Conversation

jabraham17
Copy link
Member

@jabraham17 jabraham17 commented Jan 10, 2024 •
edited
Loading

Removes almost all of the remaining BigInteger deprecations

This PR removes the deprecations from the following PRs I authored

I also removed the remaining deprecations done by Yash Raj

I moved one test out of the deprecated/BigInteger directory, bigint_getlimbs.chpl, since its not a deprecation test and actually checks functionality.

Testing

  • paratest without comm
  • paratest with comm
  • built docs and checked them

[Reviewed by @ShreyasKhandekar]

@jabraham17
remove deprecated addmul and submul
6b9c58f 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
remove bit funcs
67b3731 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
remove scan and *rem from bigint
bd9f60d 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
remove ior, popcount, and mul_2exp
76f1710 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
remove deprecated div functions and round enum
b3a782f 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
remove get_str
bc9d2a5 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
remove bigint functions with deprecated argument names
7432611 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
remove argument names test
cc491c2 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
remove perfect_power_p
f732898 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
remove perfect_square_p
43edc0d 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
remove number theory deprecations and hamdist
ec199b2 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
remove even_p and odd_p
72ce76e 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
move non-deprecation test out of deprecation folder
6d4c82c 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
remove bigint.remove
56acc78 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
fix compat module
3d1f684 
Signed-off-by: Jade Abraham <[email protected]>
ShreyasKhandekar
ShreyasKhandekar approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@ShreyasKhandekar ShreyasKhandekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just one small question about the shootout changes.

test/studies/shootout/submitted/CompatGMP.chpl Show resolved Hide resolved
@jabraham17 jabraham17 merged commit c0991b4 into chapel-lang:main Jan 11, 2024
7 checks passed
@jabraham17 jabraham17 deleted the remove-deprecated-bigint branch January 11, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShreyasKhandekar ShreyasKhandekar ShreyasKhandekar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jabraham17 @ShreyasKhandekar