Make explicit cross-version support for Pydantic #64
Conversation
curies is a distal transitive dependency of many packages, it needs to be neutral w.r.t pydantic version. It looks like it already is, and the pinning to <2 is unneccessary For more context see biopragmatics/bioregistry#920
|
I’d like to see explicit testing for both versions running. I tried this before and didn’t find it so easy unfortunately |
|
shall we get the sphinx fixed first then experiment with changes to gh actions to run with both versions of pydantic? |
|
High priority for me as well now! Thanks for getting the ball rolling! |
Codecov Report
@@ Coverage Diff @@
## main #64 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 554 554
Branches 113 113
=========================================
Hits 554 554 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I think it's the case that Pydantic rolled back some of its v1-v2 problems - one of the big issues was the config class that lives inside the actual base model subclass. This appears to be a "deprecation" now instead of being fully unavailable. This changes things wrt the previous try, making this easier. I have now solved all of the documentation and testing concerns, and can merge this + make a new release. |
cthoyt
changed the title
|
Release 0.6.0 reflects this update |
As a follow-up to biopragmatics/curies#64 (and related to #920 and #899), this PR makes Bioregistry support both Pydantic v1 and v2
curies is a distal transitive dependency of many packages, it needs to be neutral w.r.t pydantic version. It looks like it already is, and the pinning to <2 is unneccessary
For more context see biopragmatics/bioregistry#920