Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make explicit cross-version support for Pydantic #921

Merged
merged 16 commits into from
Aug 7, 2023

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Aug 5, 2023

As a follow-up to biopragmatics/curies#64 (and related to #920 and #899), this PR makes Bioregistry support both Pydantic v1 and v2

@cthoyt cthoyt changed the title [HELP WANTED] Make explicit cross-version support for Pydantic Make explicit cross-version support for Pydantic Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 96.29% and project coverage change: +0.10% 🎉

Comparison is base (4c57b37) 40.84% compared to head (b13867b) 40.94%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #921      +/-   ##
==========================================
+ Coverage   40.84%   40.94%   +0.10%     
==========================================
  Files         135      135              
  Lines        7773     7788      +15     
  Branches     1808     1810       +2     
==========================================
+ Hits         3175     3189      +14     
- Misses       4399     4400       +1     
  Partials      199      199              
Files Changed Coverage Δ
src/bioregistry/schema/struct.py 86.99% <95.00%> (+<0.01%) ⬆️
src/bioregistry/app/impl.py 80.76% <100.00%> (+0.24%) ⬆️
src/bioregistry/constants.py 100.00% <100.00%> (ø)
src/bioregistry/utils.py 67.18% <100.00%> (+1.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cthoyt cthoyt merged commit 119c641 into main Aug 7, 2023
13 checks passed
@cthoyt cthoyt deleted the pydantic-cross-compatible branch August 7, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant