-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move bioregistry to extras so that OAK is compatible with pydantic v2 #628
Comments
What bioregistry functionality does oak need beside curies? |
And why does curies have a pydantic dependency? Maybe configure as "extra"? |
|
PR for curies here: @matentzn - good point. In fact oak only has indirect dependency on bioregistry, I will update the original comment |
OK, we are good with curies. We have a problem right now in that it's easy to get into a broken state:
Until bioregistry is compatible with both, we need to either pin pydantic < 2 or pin bioregistry to a version after bioregistry pinned pydantic |
I believe the reason we had this was because an upstream was not correctly pinning and we had incompatibilities. Note we still have transitive dependencies from kgcl and sssom See #628
See INCATools/ontology-access-kit#628 Note that we still need KGCL to have a more explicit prefix management strategy
See INCATools/ontology-access-kit#628 Note that we still need KGCL to have a more explicit prefix management strategy
* Removing direct boregistry dependency as it was not used. I believe the reason we had this was because an upstream was not correctly pinning and we had incompatibilities. Note we still have transitive dependencies from kgcl and sssom See #628 * Removing bioregistry and updating dependencies to use pydantic version-neutral See #628 * Pydantic version neutral * use non-rc * latest sssom sidesteps Harold-Solbrig/funowl#60 * use latest version of funowl which no longer pings rdflib to 6.2.x
Fixed |
Oh, the wonderful world of python package dependencies. This is the only thing I don't miss about java.
llm uses pydantic2. OntoGPT will use llm and oak. oak uses pydantic1 indirectly via
We have a rc for linkml (see linkml/linkml#1545)
It looks like there is no plan to move to v2 from bioregistry in the short term biopragmatics/bioregistry#899 (comment)
I think we should be able to move to bioregistry being an extra. For most runtime use cases there is no need for external prefix lookup.
It looks like curies also requires <2:
https://github.com/cthoyt/curies/blob/859362f27bc9aec3f254d0122351341ca65bcab4/setup.cfg#L56
But expand/contract via a dict should be possible to do natively
The text was updated successfully, but these errors were encountered: