gradle metadata support (gradle-4.6)

[vvlevchenko]

No description provided.

[eyalbe4]

@vvlevchenko,
Thank you for this PR and sorry for the late reply.
The code looks okay, but we'd feel much more comfortable merging it if ti included a test for the new functionality.
The README includes instructions for running the tests.
As for adding new tests, you can see that the plugin code include these test projects. In each test project, the build.gradle references one of these build files, to create a full project to execute with gradle.
The GradleBintrayPluginSpec class includes the actual test methods, which test the above projects.

[vvlevchenko]

I've reconsidered usefulness of this PR. It tries to cover difference between Gradle's maven publication representation and bintray plugin's maven publication representation. Months later after my initial changes I've concluded that it better to avoid duplication work done in Gradle's plugin maven-publish. My suggestion to fix this issue and all future possible mismatch in representation of maven publication for users preferring bintray plugin to maven-publish is to replace current maven publication upload functionality with applying maven-publish and its proper configuration (url and etc) under the hood of bintray plugin.

[LouisCAD]

@vvlevchenko Is there an example of using maven-publish to upload artifacts to bintray?

[ilmat192]

@LouisCAD You can take a look at maven-publish usage in this project: https://github.com/h0tk3y/better-parse/blob/fb2d5fb81b2a5eaccbe30419295f21ce1f70e5b0/build.gradle#L126.

This build script also contains some additional logic to avoid publishing the same artifacts from several hosts (you can find this logic before the publishing block). You may use the same approach or just allow bintray to override artifacts published several times. To do that, just append ;override=1 to the repo URL.

[LouisCAD]

@ilmat192 Thank you, that's very helpful!
About the name propery you set to "bintray" in the maven { … } closure, do I need to name it as such too? What does it translate to from the bintray config?

[ilmat192]

About the name propery you set to "bintray" in the maven { … } closure, do I need to name it as such too?

I don't think so. According to the Gradle docs this name is needed only to distinguish repositories from each other.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}