-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
android x support #494
android x support #494
Conversation
It seems dropping native fragment support makes diff huge. Do you guys want me to split PR? @hotchemi @mannodermaus |
yea it's better I guess! |
edd66c4
to
b6729b3
Compare
Ah, one more thing, do you want me to send PR for non-master branch like |
To master is ok! But to merge this PR we need to deal with bintray-release plugin.. 🤔 |
adopted processors to honour new AndroidX package names
my android studio was in a corrupt state and showed me a running app and tests...
b6729b3
to
ac625c5
Compare
- echo "sdk.dir=$ANDROID_HOME" > local.properties | ||
- echo "sdk.dir=$ANDROID_HOME" > local.properties | ||
- mkdir "$ANDROID_HOME/licenses" || true | ||
- cp ./android-sdk-licenses/* "$ANDROID_HOME/licenses/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might not need this change because of bintray-release plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
gradle.properties
Outdated
MIN_SDK_VERSION = 14 | ||
|
||
# Gradle parameters | ||
org.gradle.daemon = true | ||
org.gradle.jvmargs = -XX:MaxPermSize=1024m -XX:+CMSClassUnloadingEnabled -XX:+HeapDumpOnOutOfMemoryError -Xmx2048m | ||
android.useAndroidX=true | ||
android.enableJetifier=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting
@@ -9,6 +9,7 @@ import permissions.dispatcher.Utils.onNeedsPermission | |||
import permissions.dispatcher.Utils.onRationaleAnnotation | |||
import permissions.dispatcher.Utils.runtimePermission | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this?
3 options I came up:
If bintray-release support gradle 4.6 is best however because they don't even support gradle 4.5, I would like to drop this plugin and migrate to official one. |
Hi, Any progress on getting a new release out that supports Android X? I have a new project that fails to compile because v4 compat (ActivityCompat) is no longer available on the generated Dispatcher. Thank you. |
I was working on replacing bintray-release with gradle-bintray-plugin. I'm not sure how I can test this fix at this moment. |
Ah sorry I jus started working on from today @shiraji may be I'm a person to test🙇 |
I'll push my code asap which is what I think it should. Then, you can test it. I really don't know if it works or not, thou |
Happy to test out the new artifact when deployed :-) -=david=- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thank you for your great work @shiraji ! |
where is the 4.0.0-alpha1 ? :) |
Tonight! |
Hi, Well, testing...and it doesn't appear to work!
When doing a full build, no generated classes seem to be created, i.e., no In my app build.gradle
-=david=- |
@dharrigan Sorry if I confused you but it's not released, yet. |
Hi, -=david=- |
@dharrigan thx for checking. are there any error log? I'm gonna test! |
Hi, No error logs - compilation succeeds normally. |
Hi, Actually, discovered the error. I had However, even with the snapshot 4.0 library (and the generated classes being generated), It's still complaining about |
I'm testing but seems working? 👁 |
Hi, Perhaps I'm missing something? I did a clean clone of the project, pulled down all the dependencies again, ensured I was using the 4.0.0-SNAPSHOT, did a build from the command line and I get the same error as in 3.3.1, i.e.,
|
@dharrigan could you try 4.0.0-alpha? 👀 Seems we failed to release library module. |
Hi, Seems like the dependency fails: Inside the pom
When added as a depdency in build.gradle:
|
OMG sorry about that. |
Umm why it happens.. |
@permissions-dispatcher/maintainers does anyone have an idea why this happens.. 🤔 |
How we can generate pom file for |
I'll send needed info privately! |
@dharrigan we've fixed by #500, can you try again? |
See #488
We need to wait bintray support gradle 4.6 or release this alpha version manually ✋TODO
NOT TODO for this PR