AndroidX #488
AndroidX #488
Conversation
adopted processors to honour new AndroidX package names
processor/build.gradle
Outdated
| testCompileAar "com.android.support:support-v4:$SUPPORT_LIBRARY_VERSION" | ||
| testCompileAar "com.android.support:support-v13:$SUPPORT_LIBRARY_VERSION" | ||
| testCompileAar 'androidx.legacy:legacy-support-v4:1.0.0-alpha3' | ||
| testCompileAar 'androidx.legacy:legacy-support-v13:1.0.0-alpha3' |
There was a problem hiding this comment.
Create a version code at gradle.properties
There was a problem hiding this comment.
I was thinking we are still keep android support library's support. Do we want to drop the support of support library?
| @@ -26,7 +24,7 @@ import permissions.dispatcher.samplekotlin.R | |||
| * Implementation is based directly on the documentation at | |||
| * http://developer.android.com/guide/topics/media/camera.html | |||
| */ | |||
| class CameraPreviewFragment : Fragment() { | |||
| class CameraPreviewFragment : androidx.fragment.app.Fragment() { | |||
|
I've fixed the mentioned issues (imports and versioning) and fixed the travis build by copying the licences to $ANDROID_HOME/licences It is failing now due to the publishing plugin. I don't know how you usually deal with this. |
|
Might be related to https://github.com/novoda/bintray-release could you try to update the ver? |
|
no luck...bintray-release does not seem to support gradle-4.6 but the android-gradle plugin for AndroidX should be the 3.2.0-alpha* |
|
Umm.. 🤔 |
|
Unfortunately I have no resources at the moment to look into bintray (have not yet deployed any artifacts to any kind of artifactory :-)). |
my android studio was in a corrupt state and showed me a running app and tests...
|
Sorry my Android Studio Canary was terribly broken and did show me successful tests and launched the sample app fine. There were a lot of compile issues in the code which Android Studio did not show me :-( Now the project should compile fine but I could not figure out how to make the test-v13 run so I ignored them for now. I would actually suggest to maybe release the AndroidX support as a new library version 4.x.y and completely drop the support for the old support-lib. |
|
Umm ok, it would be actually a huge change so it might be better to be addressed by @permissions-dispatcher/maintainers 🤔Really sorry to say that but this is actually a great work! |
|
Let me take over this work. |
|
Sure no problem! |
|
Thank you @forkch ! |
migration to AndroidX
right now i cannot build due to some maven publishing taks which are not working on my machine (or due to the new gradle plugin..)