Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_planner): use neighboring lane of pull over lane to check goal footprint #8716

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 2, 2024

Description

Check to see if the goal footprint fits in the lane with the goal searcher.

yellow lanes are for lane departure check

  • before: pull over lane and current lane

image

image

  • after: pull over lane and the same segment

image

image

Related links

Parent Issue:

How was this PR tested?

2024/09/11 https://evaluation.tier4.jp/evaluation/reports/9f6d71af-0ee5-598b-95d0-2e90e82c811e/?project_id=prd_jt
2024/09/26 https://evaluation.tier4.jp/evaluation/reports/ea55e52a-002c-5fd0-b87f-8d750378c461/?project_id=prd_jt

3871/3871

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@kosuke55 kosuke55 marked this pull request as ready for review September 2, 2024 12:32
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 2, 2024
Copy link

github-actions bot commented Sep 2, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 changed the title Fix/goal footprint feat(goal_planner): use neighboring lane of pull over lane to check goal footprint Sep 10, 2024
@kosuke55 kosuke55 force-pushed the fix/goal_footprint branch 2 times, most recently from 972ed34 to 3d40f85 Compare September 10, 2024 05:08
@kosuke55 kosuke55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.47%. Comparing base (9fd0dae) to head (89b4ee9).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...ior_path_goal_planner_module/src/goal_searcher.cpp 0.00% 3 Missing ⚠️
...are_behavior_path_goal_planner_module/src/util.cpp 96.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8716      +/-   ##
==========================================
- Coverage   28.48%   28.47%   -0.02%     
==========================================
  Files        1314     1318       +4     
  Lines       98292    98443     +151     
  Branches    39995    40020      +25     
==========================================
+ Hits        27999    28029      +30     
- Misses      70228    70349     +121     
  Partials       65       65              
Flag Coverage Δ *Carryforward flag
differential 1.27% <87.50%> (?)
total 28.45% <ø> (-0.03%) ⬇️ Carriedforward from 9fd0dae

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 force-pushed the fix/goal_footprint branch 5 times, most recently from f0b1d90 to 87b4cd6 Compare September 10, 2024 13:57
@kosuke55 kosuke55 force-pushed the fix/goal_footprint branch 3 times, most recently from 0d14e2d to b639faa Compare September 10, 2024 17:15
…oal footprint

Signed-off-by: kosuke55 <[email protected]>

move to utils and add tests

Signed-off-by: kosuke55 <[email protected]>
@kosuke55
Copy link
Contributor Author

@kosuke55 kosuke55 merged commit d10c4c2 into autowarefoundation:main Sep 26, 2024
34 of 36 checks passed
@kosuke55 kosuke55 deleted the fix/goal_footprint branch September 26, 2024 10:50
prakash-kannaiah pushed a commit to prakash-kannaiah/autoware.universe that referenced this pull request Oct 9, 2024
…oal footprint (autowarefoundation#8716)

move to utils and add tests

Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: prakash-kannaiah <[email protected]>
AkariNakano821 pushed a commit to AkariNakano821/autoware.universe that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants