refactor(dummy_perception_publisher): rework parameters

[batuhanbeytekin]

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371

Tests performed

Package built and launch locally.

Effects on system behavior

More reliable and faster parameter configuration file creation.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[github-actions]

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-8660/
Modified URLs:

• https://autowarefoundation.github.io/autoware.universe/pr-8660/sensing/autoware_pointcloud_preprocessor/downsample-filter/
• https://autowarefoundation.github.io/autoware.universe/pr-8660/sensing/autoware_pointcloud_preprocessor/pointcloud-accumulator/
• https://autowarefoundation.github.io/autoware.universe/pr-8660/simulator/dummy_perception_publisher/

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.96%. Comparing base (d57f82d) to head (c4ea773).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8660      +/-   ##
==========================================
- Coverage   27.96%   27.96%   -0.01%     
==========================================
  Files        1319     1319              
  Lines       98732    98738       +6     
  Branches    39800    39803       +3     
==========================================
  Hits        27615    27615              
- Misses      71062    71068       +6     
  Partials       55       55              

Flag	Coverage Δ		*Carryforward flag
differential	1.96% <ø> (?)
total	27.96% <ø> (ø)		Carriedforward from d57f82d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MasatoSaeki]

@batuhanbeytekin
ae2ee04 and f7d66c9 is already rebased(merged), therefore could you remove their commit?

[batuhanbeytekin]

@batuhanbeytekin ae2ee04 and f7d66c9 is already rebased(merged), therefore could you remove their commit?

Thank you for your feedback, I just updated my branch.

[MasatoSaeki]

Thank you for your working. So I am able to see Documentation.
And, I want you to remove initial value in src/node.cpp like following example.
Before

visible_range_ = this->declare_parameter("visible_range", 100.0);

After

visible_range_ = this->declare_parameter("visible_range");

[MasatoSaeki]

@batuhanbeytekin
Thank you for modifying andI left the comment.
It enables to see Documentation in my local environment. (I have no idea about points which changes not reflected on URL)

[MasatoSaeki]

declare_parameter needs to explicitly specify the type like following.

visible_range_ = this->declare_parameter<double>("visible_range");
detection_successful_rate_ = this->declare_parameter<double>("detection_successful_rate");
enable_ray_tracing_ = this->declare_parameter<bool>("enable_ray_tracing");
use_object_recognition_ = this->declare_parameter<bool>("use_object_recognition");
use_base_link_z_ = this->declare_parameter<bool>("use_base_link_z");
const bool object_centric_pointcloud = this->declare_parameter<bool>("object_centric_pointcloud");
publish_ground_truth_objects_ = this->declare_parameter<bool>("publish_ground_truth");
const unsigned int random_seed =
  static_cast<unsigned int>(this->declare_parameter<int>("random_seed"));
const bool use_fixed_random_seed = this->declare_parameter<bool>("use_fixed_random_seed");