-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(detected_object_validation): rework parameters #7750
refactor(detected_object_validation): rework parameters #7750
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
a376915
to
a2096fb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7750 +/- ##
==========================================
- Coverage 28.00% 28.00% -0.01%
==========================================
Files 1317 1317
Lines 98578 98585 +7
Branches 39776 39779 +3
==========================================
Hits 27605 27605
- Misses 70874 70881 +7
Partials 99 99
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
perception/detected_object_validation/schema/object_lanelet_filter.schema.json
Outdated
Show resolved
Hide resolved
perception/detected_object_validation/schema/object_position_filter.schema.json
Outdated
Show resolved
Hide resolved
d45cef6
to
47eb566
Compare
@batuhanbeytekin It seems like there is a conflict with main branch. Could you resolve the conflicts? |
47eb566
to
419ea47
Compare
Hi @mitsudome-r, my branch is up to date. I think the conflict has been resolved now. Thank you for your reply. |
<launch> | ||
<arg name="object_position_filter_param_file" default="$(find-pkg-share detected_object_validation)/config/object_position_filter.param.yaml"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any reasons for changing the argument name? Is it to match the name with parameter file name?
Since these arguments could be used by other launch files, it might be better to keep it the same for now. We could fix them when we refactor launch files after parameter work is done. (The same goes for other launch argument names)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@batuhanbeytekin
Please resolve conflicts.
f173d86
to
87c26bc
Compare
Signed-off-by: batuhanbeytekin <[email protected]> Signed-off-by: Batuhan Beytekin <[email protected]>
Signed-off-by: Batuhan Beytekin <[email protected]>
…lter.schema.json Co-authored-by: badai nguyen <[email protected]> Signed-off-by: batuhanbeytekin <[email protected]> Signed-off-by: Batuhan Beytekin <[email protected]>
…ilter.schema.json Co-authored-by: badai nguyen <[email protected]> Signed-off-by: batuhanbeytekin <[email protected]> Signed-off-by: Batuhan Beytekin <[email protected]>
Signed-off-by: batuhanbeytekin <[email protected]> Signed-off-by: Batuhan Beytekin <[email protected]>
Signed-off-by: batuhanbeytekin <[email protected]> Signed-off-by: Batuhan Beytekin <[email protected]>
Signed-off-by: batuhanbeytekin <[email protected]> Signed-off-by: Batuhan Beytekin <[email protected]>
Signed-off-by: Batuhan Beytekin <[email protected]>
Signed-off-by: batuhanbeytekin <[email protected]> Signed-off-by: Batuhan Beytekin <[email protected]>
Signed-off-by: batuhanbeytekin <[email protected]> Signed-off-by: Batuhan Beytekin <[email protected]>
6cb4633
to
9b3b1b5
Compare
@batuhanbeytekin |
…dation#7750) * refactor(detected_object_validation): rework parameters Signed-off-by: batuhanbeytekin <[email protected]> Signed-off-by: Batuhan Beytekin <[email protected]> * style(pre-commit): autofix Signed-off-by: Batuhan Beytekin <[email protected]> * Update perception/detected_object_validation/schema/object_lanelet_filter.schema.json Co-authored-by: badai nguyen <[email protected]> Signed-off-by: batuhanbeytekin <[email protected]> Signed-off-by: Batuhan Beytekin <[email protected]> * Update perception/detected_object_validation/schema/object_position_filter.schema.json Co-authored-by: badai nguyen <[email protected]> Signed-off-by: batuhanbeytekin <[email protected]> Signed-off-by: Batuhan Beytekin <[email protected]> * refactor(detected_object_validation): rework parameters Signed-off-by: batuhanbeytekin <[email protected]> Signed-off-by: Batuhan Beytekin <[email protected]> * refactor(detected_object_validation): rework parameters Signed-off-by: batuhanbeytekin <[email protected]> Signed-off-by: Batuhan Beytekin <[email protected]> * refactor(detected_object_validation): rework parameters Signed-off-by: batuhanbeytekin <[email protected]> Signed-off-by: Batuhan Beytekin <[email protected]> * style(pre-commit): autofix Signed-off-by: Batuhan Beytekin <[email protected]> * refactor(detected_object_validation): rework parameters Signed-off-by: batuhanbeytekin <[email protected]> Signed-off-by: Batuhan Beytekin <[email protected]> * refactor(detected_object_validation): rework parameters Signed-off-by: batuhanbeytekin <[email protected]> Signed-off-by: Batuhan Beytekin <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: batuhanbeytekin <[email protected]> Signed-off-by: Batuhan Beytekin <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
refactor(detected_object_validation): rework parameters (autowarefoundation#7750)
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371
Tests performed
Package built and launch locally.
Effects on system behavior
More reliable and faster parameter configuration file creation.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.