Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changed the package name imu_corrector to autoware_imu_corrector #598

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -196,12 +196,12 @@

### sensor_kit.xacro

We will add our sensors and remove unnecessary xacros from this file.

Check warning on line 199 in docs/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/creating-sensor-model/index.md

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (xacros)
For example,
we want
to add our lidar sensor with `velodyne_top` frame from the sensor driver,
we will add the following xacro to our sensor_kit.xacro file.
Please add your sensors to this file and remove unnecessary sensor's xacros.

Check warning on line 204 in docs/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/creating-sensor-model/index.md

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (xacros)

```xml
<!-- lidar -->
Expand Down Expand Up @@ -564,7 +564,7 @@

Then, you can launch tensorrt_yolo node via adding yolo.launch.xml on your design like that:
(i.e.,
it is included in [tier4_perception_launch](https://github.com/autowarefoundation/autoware.universe/blob/ad69c2851b7b84e12c9f0c3b177fb6a9032bf284/launch/tier4_perception_launch/launch/object_recognition/detection/camera_lidar_fusion_based_detection.launch.xml#L49-L59) package in autwoare.universe)

Check warning on line 567 in docs/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/creating-sensor-model/index.md

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (autwoare)
`image_number` argument defines your camera number

```xml
Expand Down Expand Up @@ -609,7 +609,7 @@
from launch.actions import OpaqueFunction
import yaml

def launch_setup(context, *args, **kwargs):

Check warning on line 612 in docs/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/creating-sensor-model/index.md

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (kwargs)

output_topic= LaunchConfiguration("output_topic").perform(context)

Expand Down Expand Up @@ -709,7 +709,7 @@
launch_arguments = []

def add_launch_arg(name: str, default_value=None, description=None):
# a default_value of None is equivalent to not passing that kwarg at all

Check warning on line 712 in docs/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/creating-sensor-model/index.md

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (kwarg)
launch_arguments.append(
DeclareLaunchArgument(name, default_value=default_value, description=description)
)
Expand Down Expand Up @@ -937,7 +937,7 @@
Also, you can remove dependencies and unused sensor launch files at `gnss.launch.xml`.
For example,
we will use [Clap B7 sensor](https://en.unicorecomm.com/assets/upload/file/CLAP-B7_Product_Brief_En.pdf) as a GNSS/INS and IMU sensor,
and we will use [nrtip_client_ros](https://github.com/Robeff-Technology/ntrip_client) for RTK.

Check warning on line 940 in docs/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/creating-sensor-model/index.md

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (nrtip)
Also, we will add these packages to [autoware.repos](https://github.com/leo-drive/autoware.tutorial_vehicle/blob/main/autoware.repos) file.

```diff
Expand Down Expand Up @@ -973,8 +973,8 @@
<node pkg="clap_b7_driver" exec="clap_b7_driver_node" name="clap_b7_driver" output="screen">
<param from="$(find-pkg-share clap_b7_driver)/config/clap_b7_driver.param.yaml"/>
</node>
<!-- ntrip Client -->

Check warning on line 976 in docs/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/creating-sensor-model/index.md

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (ntrip)
<include file="$(find-pkg-share ntrip_client_ros)/launch/ntrip_client_ros.launch.py"/>

Check warning on line 977 in docs/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/creating-sensor-model/index.md

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (ntrip)

Check warning on line 977 in docs/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/creating-sensor-model/index.md

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (ntrip)
</group>

<!-- NavSatFix to MGRS Pose -->
Expand All @@ -995,12 +995,12 @@
<!-- IMU corrector -->
<group>
<push-ros-namespace namespace="imu"/>
<include file="$(find-pkg-share imu_corrector)/launch/imu_corrector.launch.xml">
<include file="$(find-pkg-share autoware_imu_corrector)/launch/imu_corrector.launch.xml">
<arg name="input_topic" value="/sensing/gnss/clap/ros/imu"/>
<arg name="output_topic" value="imu_data"/>
<arg name="param_file" value="$(find-pkg-share individual_params)/config/$(var vehicle_id)/robione_sensor_kit/imu_corrector.param.yaml"/>

Check warning on line 1001 in docs/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/creating-sensor-model/index.md

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (robione)
</include>
<include file="$(find-pkg-share imu_corrector)/launch/gyro_bias_estimator.launch.xml">
<include file="$(find-pkg-share autoware_imu_corrector)/launch/gyro_bias_estimator.launch.xml">
<arg name="input_imu_raw" value="/sensing/gnss/clap/ros/imu"/>
<arg name="input_twist" value="/sensing/vehicle_velocity_converter/twist_with_covariance"/>
<arg name="imu_corrector_param_file" value="$(find-pkg-share individual_params)/config/$(var vehicle_id)/robione_sensor_kit/imu_corrector.param.yaml"/>
Expand All @@ -1016,8 +1016,8 @@
there is [Tamagawa IMU sensor](https://mems.tamagawa-seiki.com/en/) used as a IMU sensor.
You can add your IMU driver instead of the Tamagawa IMU driver.
Also,
we will launch [gyro_bias_estimator](https://github.com/autowarefoundation/autoware.universe/tree/main/sensing/imu_corrector#gyro_bias_estimator) and
[imu_corrector](https://github.com/autowarefoundation/autoware.universe/tree/main/sensing/imu_corrector#imu_corrector) at `imu.launch.xml` file.
we will launch [gyro_bias_estimator](https://github.com/autowarefoundation/autoware.universe/tree/main/sensing/autoware_imu_corrector#gyro_bias_estimator) and
[imu_corrector](https://github.com/autowarefoundation/autoware.universe/tree/main/sensing/autoware_imu_corrector#imu_corrector) at `imu.launch.xml` file.
ismetatabay marked this conversation as resolved.
Show resolved Hide resolved
Please refer these documentations for more information
(We added imu_corrector and gyro_bias_estimator at gnss.launch.xml at tutorial_vehicle,
so we will not create and use `imu.launch.xml` for tutorial_vehicle).
Expand Down Expand Up @@ -1051,13 +1051,13 @@
- <arg name="imu_raw_name" default="tamagawa/imu_raw"/>
+ <arg name="imu_raw_name" default="<YOUR-IMU_MODEL/YOUR-RAW-IMU-TOPIC>"/>
<arg name="imu_corrector_param_file" default="$(find-pkg-share individual_params)/config/$(var vehicle_id)/sample_sensor_kit/imu_corrector.param.yaml"/>
<include file="$(find-pkg-share imu_corrector)/launch/imu_corrector.launch.xml">
<include file="$(find-pkg-share autoware_imu_corrector)/launch/imu_corrector.launch.xml">
<arg name="input_topic" value="$(var imu_raw_name)"/>
<arg name="output_topic" value="imu_data"/>
<arg name="param_file" value="$(var imu_corrector_param_file)"/>
</include>

<include file="$(find-pkg-share imu_corrector)/launch/gyro_bias_estimator.launch.xml">
<include file="$(find-pkg-share autoware_imu_corrector)/launch/gyro_bias_estimator.launch.xml">
<arg name="input_imu_raw" value="$(var imu_raw_name)"/>
<arg name="input_twist" value="/sensing/vehicle_velocity_converter/twist_with_covariance"/>
<arg name="imu_corrector_param_file" value="$(var imu_corrector_param_file)"/>
Expand Down
Loading