Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changed the package name imu_corrector to autoware_imu_corrector #598

Merged

Conversation

knzo25
Copy link
Contributor

@knzo25 knzo25 commented Aug 13, 2024

Description

Documentation counterpart of autowarefoundation/autoware.universe#8222

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@knzo25
Copy link
Contributor Author

knzo25 commented Aug 13, 2024

note: pre-commit does not pass since it looks for links that will only exist when the main PR is merged

@TaikiYamada4 TaikiYamada4 added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Aug 20, 2024
Copy link
Contributor

@TaikiYamada4 TaikiYamada4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knzo25
Copy link
Contributor Author

knzo25 commented Aug 26, 2024

@ismetatabay
the parent PR was merged so this one should be ok as well 🙏
(as far as I understand the person who made the comment should resolve it)

@ismetatabay
Copy link
Member

@knzo25 sorry for the late response, I marked it as resolved thanks! 🙌

@technolojin technolojin merged commit 5be678b into autowarefoundation:main Sep 26, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants